#2834 Project admins should be able to remove their subscriptions

v1.0.0
closed
nobody
General
2015-08-20
2011-09-20
No

Admins are automatically subscribed to all tools and re-added when the project is updated. We should let admins remove their tool subscriptions permanently. But it'd still be good if new tools got all admins subscribed. See def subscribe_admins

Admins also need a way to re-subscribe to tools. Some tools have a UI for this but not all. I'm not sure the best way to accomplish this - maybe show rows in /auth/prefs for all the tools in all the my_projects that aren't already subscribed, with a way to subscribe. Right now the checkboxes are for unsubscribing, so we probably need to make the UX more consistent if we add subscribing on that page too...

Related

Tickets: #2834
Tickets: #3899

Discussion

  • Dave Brondsema

    Dave Brondsema - 2011-09-20
    • labels: --> owasp
     
  • Chris Tsai - 2012-09-26
    • labels: owasp --> owasp, p3
     
  • Dave Brondsema

    Dave Brondsema - 2012-09-26
    • labels: owasp, p3 --> owasp, p3, 42cc

    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1,3 @@
     Admins are automatically subscribed to all tools and re-added when the project is updated.  We should let admins remove their tool subscriptions permanently.  But it'd still be good if new tools got all admins subscribed.  See `def subscribe_admins`
    +
    +Admins also need a way to re-subscribe to tools.  Some tools have a UI for this but not all.  I'm not sure the best way to accomplish this - maybe show rows in /auth/prefs for all the tools in all the `my_projects` that aren't already subscribed, with a way to subscribe.  Right now the checkboxes are for unsubscribing, so we probably need to make the UX more consistent if we add subscribing on that page too...
    
     
  • Igor Bondarenko

    Igor Bondarenko - 2012-09-27

    Created #178: [#2834] Project admins should be able to remove their subscriptions (3cp)

    • status: open --> in-progress
     

    Related

    Tickets: #2834

  • Igor Bondarenko

    Igor Bondarenko - 2012-09-28

    Closed #178. Branch 42cc_2834.

    We've changed subscriptions table so that user can subscribe to/unsubscribe from given tool by checking/unchecking checkbox and pressing 'Save' button.

    Unsubscribe action removes tool subscription permanently from now, and still all admins will be subscribed to the newly installed tools (if they implemented install method properly (i.e. if they call the super().install()))

    Subscriptions list can be long so maybe we need to move it to separate page and add pagination?

    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2012-10-01
    • qa: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2012-10-30
    • status: code-review --> in-progress
     
  • Dave Brondsema

    Dave Brondsema - 2012-10-30

    Looking good, a few minor things:

    • adding a new admin to a project should subscribe them to all the tools
    • can we group the rows by project so that all rows for a single project are together, both the tools/artifacts that you're currently subscribed to and also the ones you are not subscribed to? Right now if I'm looking at a single project I have to find it in two sections of the table.

    For dealing with the length of that page, we have [#3899] tracking a few ideas.

     

    Related

    Tickets: #3899

  • Igor Bondarenko

    Igor Bondarenko - 2012-10-31

    Created #200: [#2834] Improve subscriptions page (1cp)

     

    Related

    Tickets: #2834

  • Igor Bondarenko

    Igor Bondarenko - 2012-11-05

    adding a new admin to a project should subscribe them to all the tools

    Should we remove admin/regular user subscriptions to all the tools when removing admin/user from the project?

     
  • Dave Brondsema

    Dave Brondsema - 2012-11-05

    Hm, I don't think we need to. They may want to stay subscribed, and they can unsubscribe themselves later.

    Private tools (or individual tickets) would be a concern, but I think that notifications check for permissions before being sent so that shouldn't a problem. Can you double check though?

     
  • Igor Bondarenko

    Igor Bondarenko - 2012-11-06
    • status: in-progress --> code-review
     
  • Igor Bondarenko

    Igor Bondarenko - 2012-11-06

    Private tools (or individual tickets) would be a concern, but I think that notifications check for permissions before being sent so that shouldn't a problem. Can you double check though?

    I've checked the code, notifications are really check for permissions, so it's not a problem.

    Closed #200. All changes are in branch 42cc_2834a

     
  • Dave Brondsema

    Dave Brondsema - 2012-11-07
    • status: code-review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2012-11-16
    • milestone: forge-backlog --> forge-nov-16
     

Log in to post a comment.