Apache Allura™

• size: --> 4

• combine groups & permissions page into one, for the project level
• remove the cards
• replace them with a table and use rows to list the group or permission, and its memberships
• tool permissions should

We also need to make subproject permission page continue to work. Subprojects just have a permission page, no groups page (similar to tools)

• status: open --> in-progress
• assigned_to: Jenny Steele

• status: in-progress --> code-review
• qa: ⸘Dave Brondsema‽

On allura and sftheme js/3598. To test, go to the User Permissions page in project admin. You should be able to create/delete groups, add/remove users in groups, and add/remove permissions in groups. Check that the explanatory text makes sense. Old-style permission management for tools and subprojects should still work.

Once this is ready, I could do a write-up on it for [#3801]. A full explanation of the Allura permissions system might be interesting as a possible separate post too.

• status: code-review --> open

On a pre-existing or new project, I get this error on the project's /admin/groups/ page, as well as the neighborhood's /p/admin/groups/ and some of the TestProjectAdmin tests

File '/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/ext/admin/admin_main.py', line 649 in index
  permissions_by_role = self._map_group_permissions()
File '/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/ext/admin/admin_main.py', line 612 in _map_group_permissions
  for r in role.child_roles():
AttributeError: 'ProjectRole' object has no attribute 'child_roles'

• status: open --> code-review

Looks like some code didn't get checked in. Try it now.

Team feedback:

• Add red/green color to permission icons
• Make minus icon for user remove always visible

Updated with the changes above.

• qa: Dave␣Brondsema --> Tim Van Steenburgh

• status: code-review --> in-progress

Using the default 'test' project on a sandbox. After adding 3 users to the Developer group, I clicked the Delete icon next to the first user in the list, but it was the second user that was actually deleted.

• status: in-progress --> code-review

Fixed the user delete problem.

• status: code-review --> in-progress

I'm still having the same problem. I deleted my local js/3598, checked it out from origin again, and cleared my browser cache.

I added a new group. Added a user to that group. Clicked on that user to delete it, but instead, the new user text box appeared. So I added another user. Then clicked on the first user to delete it, but instead the second user was deleted.

I also noticed that if I click on an inherited permission, I get a spinner that never goes away (unless I refresh the page).

Fixes added for these problems.

• status: in-progress --> code-review

• When I enable a perm on the Member group, the Develop group inherits it correctly, but the Admin group doesn't.
• If I click to try to remove the admin perm from the Admin group, I get a flash warning that it's not allowed (which is good), but I also get an infinite spinner on the admin perm.

• status: code-review --> in-progress

• status: in-progress --> code-review