#3607 Remove hover edit from project icon admin

v1.0.0
closed
sf-1 (616)
Admin
nobody
2015-08-20
2012-01-17
No

The hover edit for the project icon was described as "not obvious" by a new user and it was suggested we just use a regular file input. We could also take out the hover edit and add a link that says "Add an icon" (or update if there's already one) that would show file input.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2012-01-20
    • size: --> 1
     
  • Jenny Steele - 2012-02-07
    • status: open --> in-progress
    • assigned_to: Jenny Steele
     
  • Jenny Steele - 2012-02-08
    • status: in-progress --> open
     
  • Dave Brondsema

    Dave Brondsema - 2012-02-14
    • milestone: forge-feb-17 --> forge-mar-02
     
  • Jenny Steele - 2012-03-02
    • assigned_to: Jenny Steele --> nobody
     
  • Cory Johns - 2012-04-24
    • status: open --> in-progress
    • assigned_to: Cory Johns
     
  • Kyle Adams - 2012-04-24

    We currently let project admins edit their icon from the summary page in sfpy. They see a pencil icon on hover; while the space constraints on the summary page may not allow for a more obvious editing UI, I'd like to see some consistency or shared elements between the two.

     
  • Kyle Adams - 2012-04-24

    Strike that. It looks like we removed the edit project icon capability at some point. Once we've ditched SFX, putting more edit hooks back into sfpy might be worth checking into.

     
  • Cory Johns - 2012-04-24
    • status: in-progress --> code-review
    • qa: Jenny Steele
     
  • Cory Johns - 2012-04-24

    allura:cj/3607

    Changed UI to [add] / [edit] / [remove] links and added confirm before remove, since it can't be undone.

     
  • Jenny Steele - 2012-04-24
    • status: code-review --> open
     
  • Jenny Steele - 2012-04-24

    This works fine, but could look a little nicer. Instead of using plain un-styled links, could you use class="btn" or maybe an icon with a title? Also, the Save button appears in an odd place during edit. Could you move it to be next to the other buttons or at least give it some padding? Screenshot attached of Save button funkiness. I also would change the confirm to "Remove project icon? This cannot be undone."

     
  • Cory Johns - 2012-04-25
    • status: open --> code-review
     
  • Cory Johns - 2012-04-25

    Changed UI to use icons, and fixed Save button positioning in Firefox.

     
  • Jenny Steele - 2012-04-25
    • status: code-review --> closed
     

Log in to post a comment.