#3659 Git commits with square brackets in the log result in garbled output by Allura

v1.0.0
closed
nobody
General
nobody
2015-08-20
2012-01-29
Humbedooh
No

When using square brackets, [], in a git commit, the commit log on Allura, as well as the corresponding email when monitoring git changes, gets garbled, like so:
https://sourceforge.net/p/modplua/code/ci/b4d3433699b076a8aa1a414d5fb65e9111b050fb/
([==[ ]==] gets converted into ===klzzwxh:0000===).

This could probably be solved by automatically escaping any [] brackets that might be in the commit log.

Discussion

  • Humbedooh - 2012-01-29

    I should probably have escaped those brackets here as well :P
    So, to reiterate;
    [ ] brackets in a commit gets turned into the above mentioned garbled code.
    [=[ ]=] would turn into [=[ ]=].

    • Description has changed:

    Diff:

    --- old 
    +++ new 
    @@ -1,5 +1,5 @@
     When using square brackets, [], in a git commit, the commit log on Allura, as well as the corresponding email when monitoring git changes, gets garbled, like so:
     https://sourceforge.net/p/modplua/code/ci/b4d3433699b076a8aa1a414d5fb65e9111b050fb/
    -([==[ ]==] gets converted into ===klzzwxh:0000===).
    +(\[==\[ \]==\] gets converted into ===klzzwxh:0000===).
    
     This could probably be solved by automatically escaping any [] brackets that might be in the commit log.
    
    • Description has changed:

    Diff:

    --- old 
    +++ new 
    @@ -1,4 +1,4 @@
    -When using square brackets, [], in a git commit, the commit log on Allura, as well as the corresponding email when monitoring git changes, gets garbled, like so:
    +When using square brackets, \[\], in a git commit, the commit log on Allura, as well as the corresponding email when monitoring git changes, gets garbled, like so:
     https://sourceforge.net/p/modplua/code/ci/b4d3433699b076a8aa1a414d5fb65e9111b050fb/
     (\[==\[ \]==\] gets converted into ===klzzwxh:0000===).
    
     
  • Dave Brondsema

    Dave Brondsema - 2012-09-05
    • milestone: limbo --> forge-backlog
     
  • Dave Brondsema

    Dave Brondsema - 2013-04-11

    This was fixed with a Markdown upgrade some time ago

     
  • Dave Brondsema

    Dave Brondsema - 2013-04-11
    • status: open --> closed
    • Milestone: forge-backlog --> forge-apr-19
     

Log in to post a comment.