#3751 commit browser UI improvements

v1.0.0
closed
nobody
42cc (433)
SCM
nobody
2015-08-20
2012-02-16
No
  • replace next/prev terminology with newer/older. Move to bottom? Use arrows?
    • would be even better to make it scrollable, loading more with ajax as needed
  • select the first commit by default, so you can initially see how that part works
  • remove extra whitespace at the top of the first page
  • change "Tree" link to "Browse code at this revision" (too long?) This is the same page as a regular commit view, so that would be affected too.
  • change colors in the commit browser, so Hue varies and is distinguishable for red/green colorblind users

https://sourceforge.net/p/tools4bci/libtia/code/commit_browser is a good, interesting one to test with

Related

Tickets: #3751

Discussion

  • Dave Brondsema

    Dave Brondsema - 2012-02-16
    • Description has changed:

    Diff:

    --- old 
    +++ new 
    @@ -1,4 +1,6 @@
     * replace next/prev terminology with newer/older.  Use arrows?
    -* select the first commit, so you can initially see how that part works
    -* there is extra whitespace at the top of the first page
    +* select the first commit by default, so you can initially see how that part works
    +* remove extra whitespace at the top of the first page
     * change "Tree" link to "Browse code at this revision" (?)
    +
    +https://sourceforge.net/p/tools4bci/libtia/code/commit_browser is a good, interesting one to test with
    
    • component: General --> SCM

    • Description has changed:

    Diff:

    --- old 
    +++ new 
    @@ -1,4 +1,4 @@
    -* replace next/prev terminology with newer/older.  Use arrows?
    +* replace next/prev terminology with newer/older.  Move to bottom? Use arrows?
     * select the first commit by default, so you can initially see how that part works
     * remove extra whitespace at the top of the first page
     * change "Tree" link to "Browse code at this revision" (?)
    
     
  • Dave Brondsema

    Dave Brondsema - 2012-03-12
    • Description has changed:

    Diff:

    --- old 
    +++ new 
    @@ -2,5 +2,6 @@
     * select the first commit by default, so you can initially see how that part works
     * remove extra whitespace at the top of the first page
     * change "Tree" link to "Browse code at this revision" (?)
    +* change colors in the commit browser, so Hue varies and is distinguishable for red/green colorblind users
    
     https://sourceforge.net/p/tools4bci/libtia/code/commit_browser is a good, interesting one to test with
    
     
  • Dave Brondsema

    Dave Brondsema - 2012-08-15
    • labels: --> 42cc
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,7 +1,7 @@
     * replace next/prev terminology with newer/older.  Move to bottom? Use arrows?
     * select the first commit by default, so you can initially see how that part works
     * remove extra whitespace at the top of the first page
    -* change "Tree" link to "Browse code at this revision" (?)
    +* change "Tree" link to "Browse code at this revision" (too long?)  This is the same page as a regular commit view, so that would be affected too.
     * change colors in the commit browser, so Hue varies and is distinguishable for red/green colorblind users
    
     https://sourceforge.net/p/tools4bci/libtia/code/commit_browser is a good, interesting one to test with
    
     
  • Dave Brondsema

    Dave Brondsema - 2012-08-15
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,4 +1,5 @@
     * replace next/prev terminology with newer/older.  Move to bottom? Use arrows?
    +    * would be even better to make it scrollable, loading more with ajax as needed
     * select the first commit by default, so you can initially see how that part works
     * remove extra whitespace at the top of the first page
     * change "Tree" link to "Browse code at this revision" (too long?)  This is the same page as a regular commit view, so that would be affected too.
    
     
  • Yaroslav Luzin

    Yaroslav Luzin - 2012-09-04
    • status: open --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2012-09-06

    Closed #153. Branch 42cc_3751.

    We made a commit list scrollable, but all commits are loaded with one ajax call.
    This is because commit_browser_data calculates the full commit tree with the parent-child relations and we see no way to calculate only that part of the tree that needed.

    If this behavior is not acceptable, we'll keep looking for another solution.

    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2012-09-10

    Is it possible to make the canvas a regular scrollable element, rather than handling the browser's events for mouse scrolling directly? It would be better if this used regular scrolling so that there was a scrollbar, and on mobile devices scrolling worked. Right now this change requires that users have a scrollwheel or scrollable touchpad.

    • status: code-review --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2012-09-19

    We'll investigate this.

    Created #169: [#3751] make the canvas a regular scrollable element (2cp)

     

    Related

    Tickets: #3751

  • Igor Bondarenko

    Igor Bondarenko - 2012-09-24

    Closed #169. All changes in a branch 42cc_3751.

    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2012-09-25
    • status: code-review --> closed
    • milestone: forge-backlog --> forge-oct-05
     

Log in to post a comment.