#3775 commit notifications should say the branch, and use markdown
http://screencast.com/t/zMVPh6huD should include the branch(es) that the commits are on. Each commit should have a link to view it. And each commit should go through standard markdown processing.
created #43: [3775] commit notifications should say the branch, and use markdown (2cp)
Originally by: tramadolmen
I have generated this notification message:
It seems that link in tags not showed. Can i place link without tags?
I'm pretty sure the notification message should be Markdown and then links will be generated properly for text/plain and text/html components of the HTML. Perhaps you just need to add the domain (
config['base_url']) and the links will work.closed #43, please check branch '42cc_3775'
The branch name in brackets like
[master]doesn't work well when it gets converted to html because brackets are used for links and there's not an artifact called master, so the brackets get dropped. Maybe(master)would be better. Ormaster: sample commit messageI don't think _make_notification needs to do markdown conversion since mail_tasks.py already has that logic. (see the end of the
sendmailfunction). Moreover, within_make_notification, thec.user.get_pref('email_format')refers to the committer, not the recipient. Will it work without modifying _make_notification at all?And then can you add the branch name and link for the notification of a single commit also? Markdown/html works correctly for a single commit notification.
Thanks
Created #70: [#3775] Refactoring and small amendments (1cp)
Related
Tickets:
#3775Closed #70 and updated 42cc_3775 branch. There's one merge commit in the branch, it should disappear when you'll make git rebase. I could not get the two branches (in your and our repository) merged/rebased without that commit.