#3830 Ming>=0.2.2dev-20120210 does stricter type checking on instrumented types

v1.0.0
closed
sf-2 (994)
General
Cory Johns
2015-08-20
2012-03-01
No

The new Ming build does stricter type checking, causing some Allura tests to fail. Need to update Allura code to fix the failures before we can move to the new Ming.

Related

Tickets: #3712

Discussion

    • status: in-progress --> code-review
    • qa: Cory Johns
     
  • forge:tv/3830

    Mainly just a code review - all the tests pass.

    If you want to run the tests or browse allura, you'll need to install the new version of Ming (http://downloads.sourceforge.net/project/merciless/0.2.2dev-20120210/Ming-0.2.2dev-20120210.tar.gz) in your allura virtualenv.

    In my testing of the Allura Tracker home page with a dataset from prod, page load time went from ~4.6s on dev to ~2.4s on this branch.

     
  • Cory Johns - 2012-03-02
    • status: code-review --> in-progress
     
  • To ssh://engr.geek.net/forge
    + 7c2ded0...09db174 tv/3830 -> tv/3830 (forced update)

    Updated Ming to truncate DateTimes at milliseconds instead of seconds. New build is here: http://downloads.sourceforge.net/project/merciless/0.2.2dev-20120302/Ming-0.2.2dev-20120302.tar.gz

    Updated tv/3820 to remove the now-unnecessary sleep(1) from the mod_date test.

    • status: in-progress --> code-review
     
    • status: code-review --> in-progress
     
    • status: in-progress --> code-review
     
  • Cory Johns - 2012-03-05
    • status: code-review --> closed
     
  • Cory Johns - 2012-03-05

    Looks good, new version on internal repo, tests pass. Merged.

     
  • Dave Brondsema

    Dave Brondsema - 2012-03-09
    • size: --> 2
     

Log in to post a comment.