#3881 Display entire commit diff on the commit index pages.

v1.0.0
closed
sf-4 (350)
General
nobody
2015-08-20
2012-03-12
Anonymous
No

Originally created by: algorithms

Instead of showing individual files with links to each diff, we should just display the entire commit history. We could even use some pjax to enable loading on demands as the user scrolls to that the load time isn't impacted. This will make the flow of the merge request process much nicer.

Discussion

  • Cory Johns - 2012-03-13
    • status: open --> in-progress
    • assigned_to: Cory Johns
     
  • Cory Johns - 2012-03-19
    • status: in-progress --> code-review
    • qa: Jenny Steele
     
  • Cory Johns - 2012-03-19

    allura: cj/3881

    To QA: Create an Allura project and add at least one commit with a multi-line commit message, and a content add, change, and remove (renames show up as a remove and an add, due to limitations of our cached commit info). View the commit browser for that commit and ensure everything looks pretty, the inline diffs reflect the actual changes, and that they match up with the linked diffs.

     
  • Cory Johns - 2012-03-19

    NB: As I mentioned, diffs for removed files do not work due to how the traversal of the commit views work, and are thus just placeholders. These did not previously show diffs, though, so it should be ok (although not ideal). I did fix diffs for added files not working.

     
  • Dave Brondsema

    Dave Brondsema - 2012-03-19
    • milestone: forge-backlog --> forge-mar-23
     
  • Cory Johns - 2012-03-19
    • size: --> 4
     
  • Jenny Steele - 2012-03-20
    • status: code-review --> closed
     
  • Cory Johns - 2012-03-20
    • status: closed --> in-progress
     
  • Cory Johns - 2012-03-20

    Failing test due to not passing HTML5 validation.

     
  • Cory Johns - 2012-03-20
    • status: in-progress --> code-review
     
  • Cory Johns - 2012-03-20

    allura:cj/3881
    sftheme:cj/3881

    Changed structure of commit details section to pass HTML5 validation, and cleaned up the author / committer and parents / children section.

     
  • Jenny Steele - 2012-03-21
    • status: code-review --> closed
     

Log in to post a comment.