#3931 Commit diff viewer should use file line numbers.

unreleased
review
nobody
SCM
2015-03-17
2012-03-20
Anonymous
No

Originally created by: algorithms

Our current method for line numbering using pygments is dumb, meaning it doesn't under stand that when showing the output of a commit diff, it should use the line numbers from the original file(s) not just number them 1-n. Other tools that have solved this problem are ReviewBoard and Trac. Maybe look to their source for examples.

Related

Tickets: #3931

Discussion

  • Jenny Steele

    Jenny Steele - 2012-06-06
    • labels: --> v2
     
  • Dave Brondsema

    Dave Brondsema - 2012-08-15
    • labels: v2 --> v2, 42cc
    • summary: Commit viewer should use file line numbers. --> Commit diff viewer should use file line numbers.
    • component: General --> SCM
     
  • Yaroslav Luzin

    Yaroslav Luzin - 2012-08-17

    Created #152: [#3931] Commit diff viewer should use file line numbers (3cp)

    • status: open --> in-progress
     

    Related

    Tickets: #3931

  • Anonymous - 2012-08-17

    Originally by: algorithms

    We received permission from the author of rhodecode to re-license parts of his code under ASF. His diff lib is better than ours currently and gets line numbering correct.

    https://bitbucket.org/marcinkuzminski/rhodecode/src

     
  • Igor Bondarenko

    Igor Bondarenko - 2012-09-04
    • status: in-progress --> code-review
     
  • Igor Bondarenko

    Igor Bondarenko - 2012-09-04

    Closed #152. Branch 42cc_3931

     
  • Dave Brondsema

    Dave Brondsema - 2012-10-05
    • qa: Dave Brondsema
     

Log in to post a comment.