#3938 Stats logging should not go to the "console" handler; remove it NEEDS INI CHANGE

unreleased
closed
cleanup (28)
General
nobody
2020-02-22
2012-03-22
No

We use h.log_action in many places to log details about actions that happen. In production.ini, handler_stats is configured to write those details to a separate log file. But they still go to handler_console too. To have them not go there, I think we need a the log_action events to go to a different base logger (e.g. allura.stats) instead of whatever package logger is there (e.g. allura.model.repo_refresh). class StatsHandler filters by checking for an "action" attribute on the event, but we need a simple way to separate them so that it can be adjusted via the logging ini settings.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2016-08-31
    • labels: --> cleanup
    • summary: Stats logging should not go to the "console" handler --> Stats logging should not go to the "console" handler; remove it
     
  • Dave Brondsema

    Dave Brondsema - 2016-08-31

    I think the h.log_action code and related logging configuration can be removed completely. The activity stream is a better way to keep track of actions. And /rest/ api activity in specific generates a lots of unnecessary log entries now.

     
  • Dave Brondsema

    Dave Brondsema - 2019-10-14
    • status: open --> review
    • assigned_to: Dave Brondsema
     
  • Kenton Taylor

    Kenton Taylor - 2019-10-15
    • status: review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2020-02-22
    • summary: Stats logging should not go to the "console" handler; remove it --> Stats logging should not go to the "console" handler; remove it NEEDS INI CHANGE
     
  • Dave Brondsema

    Dave Brondsema - 2020-02-22

    Upgrade notes:

    If you have customized development.ini or docker-dev.ini for your own site, you will need to remove all the stats references after the "Logging configuration" section. Remove it from 2 keys = lists, and 1 handlers =list, and the whole [handler_stats] subsection.

     

Log in to post a comment.