#3985 Project macro cleanup

v1.0.0
closed
nobody
42cc (432)
General
2015-08-20
2012-03-30
No

Prior related tickets: [#3926] [#3927] [#3928]

  • There's a typo in "last_registred" It should be "last_registered"
  • We actually have some tests for the [[projects]] macro already in Allura/allura/tests/test_globals.py (def test_macros). I grepped for [[projects to find them. Can you update the tests to be alongside the other similar ones in test_globals.py?
  • the projects() macro function should convert show_download_button and show_proj_icon to bool right away. Then the templates and default values in project_list.py can be booleans rather than "on" and "off" strings.
  • changing "columns" doesn't have any affect. This should change the "list" mode into 1, 2, or 3 columns for compact display of lots of projects. You'll have to have show_download_button=off and override .list.card h2 { left: 55px } for it to fit.

Related

Tickets: #3926
Tickets: #3927
Tickets: #3928

Discussion

  • Yaroslav Luzin - 2012-04-02

    Created #36: [3985] Project macro cleanup (1cp)

     
  • Anonymous - 2012-04-03

    Originally by: *anonymous

    Can you give me more information about this:

    changing "columns" doesn't have any affect. This should change the "list" mode into 1, 2, or 3 columns for compact display of lots of projects. You'll have to have show_download_button=off and override .list.card h2 { left: 55px } for it to fit.

    On my local machine columns are worked (only columns=2 and columns=3). If i right understand you - you want to add columns=1. For what columns value i must set show_download_button=off and override .list.card h2 { left: 55px }?

     
  • Yaroslav Luzin - 2012-04-12

    Closed ticket #36 '3985 Project macro cleanup' and pushed changes into 42cc_3985

     
  • Dave Brondsema

    Dave Brondsema - 2012-04-16
    • status: open --> closed
    • qa: ⸘Dave Brondsema‽
    • size: --> 0
    • milestone: forge-backlog --> forge-apr-20
     
  • Dave Brondsema

    Dave Brondsema - 2012-04-16

    Merged to dev. By the way, I realized that the standard theme doesn't support "list" mode like our sourceforge theme does. So that probably added some confusion.

     

Log in to post a comment.