#4077 change ForumPost links to go to thread url, with target

v1.0.0
closed
nobody
General
2015-08-20
2012-04-18
No

The "latest posts" on a discussion landing page, and the Post results when searching a forum (or the whole app) link to a single post but it would be much nicer to link to the thread with a #target, so you can read all the context.

Pagination could be a tricky, since a post might not be on the first page of the thread, and user preferences can set different items per page (iirc). Find the existing logic for the "link" link on each comment, perhaps that can be re-used. It does account for pagination.

We can also limit the Forum search to Post documents (no Thread docs).

Related

Tickets: #3915
Tickets: #3916
Tickets: #4077
Tickets: #4807

Discussion

  • Dave Brondsema

    Dave Brondsema - 2012-04-19

    Make sure this works in general, including the 'latest post' links on the Forum tool index page.

     
  • Dave Brondsema

    Dave Brondsema - 2012-08-15
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,4 +1,4 @@
    -If you search a forum (or the whole app) and get Post results, they link to that single post but it would be much nicer to link to the thread with a #target, so you can read all the context.
    +The "latest posts" on a discussion landing page, and the Post results when searching a forum (or the whole app) link to a single post but it would be much nicer to link to the thread with a #target, so you can read all the context.
    
     Pagination could be a tricky, since a post might not be on the first page of the thread, and user preferences can set different items per page (iirc).  Find the existing logic for the "link" link on each comment, perhaps that can be re-used.  It does account for pagination.
    
    • milestone: forge-backlog --> forge-sep-07
     
  • Dave Brondsema

    Dave Brondsema - 2012-09-07
    • size: --> 2
     
  • Dave Brondsema

    Dave Brondsema - 2012-09-10
    • labels: ux --> ux, 42cc
    • milestone: forge-oct-05 --> forge-backlog
     
  • Igor Bondarenko - 2012-09-11

    Created #166: [#4077] change ForumPost links to go to thread url, with target (2cp)

    • status: open --> in-progress
     

    Related

    Tickets: #4077

  • Igor Bondarenko - 2012-09-17

    Closed #166. Branch 42cc_4077.

    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2012-09-18
    • qa: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2012-09-20
    • status: code-review --> closed
    • size: 2 --> 0
    • milestone: forge-backlog --> forge-sep-21
     
  • Dave Brondsema

    Dave Brondsema - 2012-09-20

    Note: there is some marginal slowdown for the extra mongo queries, we could do some per-request caching in case the same thread is listed multiple times in a search result page, but I don't think that is necessary at this point.

     

Log in to post a comment.