#4296 This must be unicode: 'noreply@in.sf.net'

v1.0.0
closed
sf-1 (616)
General
nobody
2015-08-20
2012-05-30
No
Module allura.tasks.mail_tasks:110 in sendmail
<<      smtp_client.sendmail(
               addrs_multi, fromaddr, reply_to, subject, message_id,
               in_reply_to, multi_msg)
           smtp_client.sendmail(
               addrs_plain, fromaddr, reply_to, subject, message_id,
>>  in_reply_to, multi_msg)
Module allura.lib.mail_util:173 in sendmail
<<          # It might be nice to refactor to send one message per recipient, and use the actual To: addr
               message['To'] = Header(reply_to)
               message['From'] = AddrHeader(fromaddr)
               message['Reply-To'] = Header(reply_to)
               message['Subject'] = Header(subject)
>>  message['From'] = AddrHeader(fromaddr)
Module allura.lib.mail_util:56 in AddrHeader
<<              addrheader = Header(name, addr)
           else:
               addrheader = Header(fromaddr)
           return addrheader
>>  addrheader = Header(fromaddr)
Module allura.lib.mail_util:33 in Header
<<      # see http://docs.python.org/library/email.header.html#email.header.Header.append
           if type(text) != unicode:
               raise TypeError('This must be unicode: %r' % text)
           head = header.Header(text)
           for m in more_text:
>>  raise TypeError('This must be unicode: %r' % text)
TypeError: This must be unicode: 'noreply@in.sf.net'

Discussion

  • Dave Brondsema

    Dave Brondsema - 2012-05-30
    • status: in-progress --> code-review
    • qa: Jenny Steele
     
  • Dave Brondsema

    Dave Brondsema - 2012-05-30

    forge:db/4296 No tests since I don't know exactly where it's coming from, but I just changed all the noreply hard-coded strings to be unicode.

     
  • Jenny Steele - 2012-05-31
    • status: code-review --> closed
     

Log in to post a comment.