#4429 ticket bulk-edit forcibly always sets all custom boolean fields to True [26300]

v1.1.0
closed
nobody
General
Cory Johns
2015-08-20
2012-06-21
Chris Tsai
No

https://sourceforge.net/apps/trac/sourceforge/ticket/26300

This is on a project using the Beta Allura platform.

I was trying to use bulk-edit to set some custom boolean fields to 'False'. I left the corresponding boxes unchecked and hit the 'Save' button. The fields got set to 'True' instead. This seems reliably reproducible.

In fact, it appears that there's no option to leave boolean fields unchanged during a bulk edit. As far as I can tell, any bulk-edited tickets get all of their custom boolean fields set to True.

Confirmed exactly as described.

Related

Tickets: #4429

Discussion

  • Dave Brondsema

    Dave Brondsema - 2012-07-13
    • milestone: limbo --> forge-backlog
     
  • Chris Tsai - 2012-09-26
    • labels: support --> support, p3
     
  • Dave Brondsema

    Dave Brondsema - 2013-10-14
    • labels: support, p3 --> support, p3, 42cc
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-10-15

    I can reproduce the first part (not possible to set fields to False, using bulk edit), but can not reproduce the second part. Can you describe steps to reproduce that? It seems to me that now unchecked checkbox means "don't change field value", and checked means "set it to True".

    If we change uncheked checkbox meaning to "set to False" we would have problems with keeping field's old value. For example, when you edit some other field and leave checkbox untouched, you set all boolean fields in affected tickets to False.

    I think, we should consider UI changes for this. For every boolean field show radio-group with three options: Don't change (default), True, False.

    Any thoughts on this?

     
  • Dave Brondsema

    Dave Brondsema - 2013-10-15

    I haven't reproduced this myself, so can't describe the steps.

    But I do agree with using radio buttons or drop-down with 3 options, as you suggest.

     
  • Igor Bondarenko

    Igor Bondarenko - 2013-10-15
    • status: open --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-10-15

    Created #458: [#4429] Improve custom boolean fields in bulk edit (2cp)

    We'll go with drop-down, I think it'll be cleaner than radio buttons. Thanks.

     

    Related

    Tickets: #4429

  • Igor Bondarenko

    Igor Bondarenko - 2013-10-24
    • status: in-progress --> code-review
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-10-24

    Closed #458. je/42cc_4429

     
  • Cory Johns

    Cory Johns - 2013-10-24
    • QA: Cory Johns
     
  • Cory Johns

    Cory Johns - 2013-10-24
    • status: code-review --> closed
    • Milestone: forge-backlog --> forge-nov-01
     
  • Cory Johns

    Cory Johns - 2013-10-24

    Minor style improvement: I changed:

    if v == u'True':
        v = True
    elif v == u'False':
        v = False
    

    to:

    v = asbool(v)
    

    from paste.deploy.converters

     

Log in to post a comment.