#4429 ticket bulk-edit forcibly always sets all custom boolean fields to True [26300]
closed
nobody
General
2015-08-20
2012-06-21
No
https://sourceforge.net/apps/trac/sourceforge/ticket/26300
This is on a project using the Beta Allura platform.
I was trying to use bulk-edit to set some custom boolean fields to 'False'. I left the corresponding boxes unchecked and hit the 'Save' button. The fields got set to 'True' instead. This seems reliably reproducible.
In fact, it appears that there's no option to leave boolean fields unchanged during a bulk edit. As far as I can tell, any bulk-edited tickets get all of their custom boolean fields set to True.
Confirmed exactly as described.
I can reproduce the first part (not possible to set fields to False, using bulk edit), but can not reproduce the second part. Can you describe steps to reproduce that? It seems to me that now unchecked checkbox means "don't change field value", and checked means "set it to True".
If we change uncheked checkbox meaning to "set to False" we would have problems with keeping field's old value. For example, when you edit some other field and leave checkbox untouched, you set all boolean fields in affected tickets to False.
I think, we should consider UI changes for this. For every boolean field show radio-group with three options: Don't change (default), True, False.
Any thoughts on this?
I haven't reproduced this myself, so can't describe the steps.
But I do agree with using radio buttons or drop-down with 3 options, as you suggest.
Created #458: [#4429] Improve custom boolean fields in bulk edit (2cp)
We'll go with drop-down, I think it'll be cleaner than radio buttons. Thanks.
Related
Tickets:
#4429Closed #458.
je/42cc_4429Minor style improvement: I changed:
if v == u'True': v = True elif v == u'False': v = Falseto:
from paste.deploy.converters