#4667 TOC hierarchy bug / upgrade Markdown

v1.0.0
closed
nobody
42cc (432) migration (63) p3 (267)
General
Dave Brondsema
2015-08-20
2012-08-07
Dave Brondsema
No

The TOC on https://sourceforge.net/p/forge/documentation/API%20-%20Beta/?version=10 shows an incorrect hierarchy. It doesn't match the section headers

Related

Tickets: #2385
Tickets: #4667

Discussion

  • Dave Brondsema

    Dave Brondsema - 2012-09-21
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2012-09-21

    Looks like the latest Markdown will fix this

     

  • Dave Brondsema

    Dave Brondsema - 2012-10-02
    • labels: --> 42cc
    • summary: TOC hierarchy bug --> TOC hierarchy bug / upgrade Markdown
    • status: in-progress --> open
    • assigned_to: Dave Brondsema --> nobody
     

  • Dave Brondsema

    Dave Brondsema - 2012-10-02

    I have begun this work on db/4667 but don't have time to complete it right now. Upgrading Markdown is causing several other issues. I've fixed some of them on the db/4667 branch, but further work is needed. The biggest issue is with the [TOC] macro and artifact links ([WikiPage] or [tickets:#1234]). 0d9cacfeb5c5518af3236495e511593a577f66ea addresses some of the TOC syntax issues, but the real problem is in artifact links which I started working on in 4a964997122dfb95cff538764a735efdecb7b58a by changing the pre-process post-process approach to an inline expansion. This seems more correct and should avoid the problem of double-processing from the TOC macro. I was starting to implement the artifact link by extending Markdown's own ForgeLinkPattern class. That will have the benefit of resolving [#2385] if it works.

     

    Related

    Tickets: #2385

  • Igor Bondarenko - 2012-10-03

    Created #183: [#4667] TOC hierarchy bug / upgrade Markdown (2cp)

    • status: open --> in-progress
     

    Related

    Tickets: #4667

  • Igor Bondarenko - 2012-10-11

    Closed #183. Branch 42cc_4667.

    We have changed artifact links and macro to use an inline expansion. It fixes [#2385] as well.

    • status: in-progress --> code-review
     

    Related

    Tickets: #2385

  • Dave Brondsema

    Dave Brondsema - 2012-10-29
    • qa: Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2012-10-29
    • status: code-review --> in-progress
     

  • Dave Brondsema

    Dave Brondsema - 2012-10-29

    Found one issue so far:

    • The [[project_admins]] macro generates two <br> tags between each project admin link, instead of one.
     

  • Igor Bondarenko - 2012-11-02

    Created #203: [#4667] Fix project_admins macro (1cp)

     

    Related

    Tickets: #4667

  • Dave Brondsema

    Dave Brondsema - 2012-11-02
    • labels: --> 42cc, migration
     

  • Igor Bondarenko - 2012-11-02

    Hm, I've tried it on a sandbox and it generates one <br> for me:

    <p>
  <a href="/u/dovethunder/">Dovethunder Bitman</a><br>
  <a href="/u/user07/">User 07</a><br>
</p>

    What I did:

    • checkout the branch
    • pip install -r requirements.txt to install new markdown
    • service httpd restart
     

  • Chris Tsai - 2012-11-05
    • labels: 42cc, migration --> 42cc, migration, p3
     

  • Igor Bondarenko - 2012-11-06

    Closed #203. Branch 42cc_4667

     

  • Igor Bondarenko - 2012-11-06
    • status: in-progress --> code-review
     

  • Dave Brondsema

    Dave Brondsema - 2012-11-07
    • status: code-review --> closed
    • milestone: forge-backlog --> forge-nov-16
     

Log in to post a comment.