#4905 subscribe to a wiki [ss518]

v1.2.0
closed
General
2015-08-20
2012-09-11
Chris Tsai
No

[forge:site-support:#518]

Hello,

Is it possible for a developer to subscribe to all documentation updates within all pages of a wiki? For me as an admin, this seems to be the case without further action, but I did not find out how a developer can switch this on or off.

Kind regards,
Andreas.

Probably not huge demand for this, but still, it makes sense to me.

Related

Tickets: #5702
Tickets: #7685

Discussion

1 2 > >> (Page 1 of 2)
  • Dave Brondsema

    Dave Brondsema - 2012-09-26

    We added this UI for subscribing to SCM tools, could do similar for Wiki

     
  • Dave Brondsema

    Dave Brondsema - 2012-09-26
    • milestone: limbo --> forge-backlog
     
  • Chris Tsai - 2012-09-26

    The gotcha for this one though is that the base tool URL redirects to a specified page. So, not sure where we'd want to put the subscribe link.

     
  • Anonymous - 2014-06-27

    Originally by: ligc

    HI,

    We got the same issue, we migrated from Mediawiki to Apache Allura Wiki platform this week, we can not subscribe to the whole wiki any more, we could only subscribe to one page, we have more than 600 wiki pages, it does not seem reasonable to ask our developers/testers/users to subscribe to each individual page.

    The last update in this bug was posted two years ago, any update after the last update?

     
  • Dave Brondsema

    Dave Brondsema - 2014-08-15
    • labels: support, p3 --> support, p3, 42cc
    • status: open --> in-progress
    • assigned_to: Igor Bondarenko
     
  • Dave Brondsema

    Dave Brondsema - 2014-08-22
    • Milestone: forge-backlog --> forge-sep-5
     
  • Dave Brondsema

    Dave Brondsema - 2014-08-22
    • Size: --> 1
     
  • Igor Bondarenko - 2014-08-26
    • status: in-progress --> code-review
     
  • Igor Bondarenko - 2014-08-26

    Closed #634. je/42cc_4905

    Added an icon to the icon bar of every page. Ideally, we need another icon for that, since there's two identical icons next to each other right now...

     
  • Dave Brondsema

    Dave Brondsema - 2014-09-08
    • Milestone: forge-sep-5 --> forge-sep-19
     
    • QA: Alexander Luberg
     
  • 1) I think it is quite confusing that we have the same icon for "subscribe to page" & "subscribe to wiki"
    2) If I click subscribe to wiki, it goes blue(checked), if I click subscribe to the page after that it doesn't become checked/blue.
    If I click subscribe to page, it goes blue(checked) and if I click subscribe to wiki after that, subscribe to wiki becomes checked and 'subscribe to the page' becomes unchecked

     
  • Igor Bondarenko - 2014-09-10
    1. Yeah, I agree. Do we have appropriate icon for that?

    2. That's because Allura subscription system works that way. When you are subscribing to entire tool, your subscription to a page disappears, since tool subscription will provide you with updates for that page. The same reason applies to the opposite situation - you can't subscribe to a page, since you already have a subscription to entire tool. I agree it's confusing... Does someone has ideas how to represent it better in the UI?

     
    • QA: Alexander Luberg --> Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2014-09-11
    • status: code-review --> in-progress
     
  • Dave Brondsema

    Dave Brondsema - 2014-09-11

    I think it would be best to avoid the adjacent icons altogether. Even if we did find/create a new icon it would still inherently be very similar to the existing icon since they do similar things.

    Instead, I would put the new button on the sidebar instead of in the action bar for the page. The action bar is all things that are per-page, so it would be best to keep that commonality and put the button to subscribe to the whole wiki elsewhere. I think the sidebar is good, it also give us room to make a text button "Subscribe to wiki" and even include the mail icon if we want. One downside is that some wikis have enabled the option to hide the left side bar on wiki pages. But you can still get the left bar if you go to the search or browse page.

    We should also have a simple test for the controller method.

     
  • Igor Bondarenko - 2014-09-12

    Closed #655. Rebased and force-pushed je/42cc_4905

     
  • Igor Bondarenko - 2014-09-12
    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2014-09-12

    Looking good, but making a change should require a POST, so that CSRF isn't possible. I don't know if we have any examples or existing ways for a SitemapEntry to be form button or do a javascript post though. I don't have a good recommendation, but I think the right course of action is to establish a way for a sidebar button to do a POST submit. Maybe javascript to change the onclick action to a POST, so you at least don't have to worry about a real button looking different?

     
  • Dave Brondsema

    Dave Brondsema - 2014-09-12
    • status: code-review --> in-progress
     
  • Igor Bondarenko - 2014-09-15

    Created a ticket to address that. All of the subscribe icons at the topbar are using GET for this, though. Do you want to change them to POST also?

     
  • Dave Brondsema

    Dave Brondsema - 2014-09-15

    Yeah, we should. Do you want to make a separate Allura ticket for it as it really is a separate issue from the original functionality in this ticket?

    And then I'd be ok with merging this as it is now. It does what its supposed to and I think it's ok for a little while to not have CSRF protection.

     
  • Igor Bondarenko - 2014-09-16

    Yep, created [#7685]

     

    Related

    Tickets: #7685

  • Igor Bondarenko - 2014-09-16
    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2014-09-16
    • status: code-review --> closed
     
1 2 > >> (Page 1 of 2)

Log in to post a comment.