#4929 better diff links between revisions [ss524]

v1.0.0
closed
nobody
General
Cory Johns
2015-08-20
2012-09-13
Chris Tsai
No

[forge:site-support:#524]

With the old browser you could browse in the tree to any single file and when you clicked on it you saw all the commits for that file. You could click on any commit and you had options to diff that commit with the previous.

Related

Tickets: #4929

Discussion

  • Dave Brondsema
    Dave Brondsema
    2012-10-02

    Created [#5037] for viewing the commits for a single file/dir. Limiting this particular ticket to showing better diff links on the history pages.

     

    Related

    Tickets: #5037

  • Dave Brondsema
    Dave Brondsema
    2012-10-02

    • summary: code browser diff improvements [ss524] --> better diff links between revisions [ss524]
    • milestone: limbo --> forge-backlog
     

  • Anonymous
    2013-02-07

    Originally by: dcommander

    I would add clarification that what the new viewer needs to do is what ViewVC used to do: that is, provide the ability to diff between any two arbitrary revisions of a file, not just consecutive revisions.

     
  • Dave Brondsema
    Dave Brondsema
    2013-03-07

    The diff view for individual files supports URL parameters specifying any arbitrary revisions (not just adjacent ones). For example https://sourceforge.net/p/blacknova/code/2463/tree/branches/original/docs/changes?diff=2461

    However, we don't expose a UI to get there. We also don't have a way to view diffs of multiple files (which ViewVC doesn't do either, but would be nice someday).

    (Note, SVN diff links have ?diff=<hash>:<rev> and <hash>: doesn't seem to be necessary - would be nice to remove that I think)

     
  • Dave Brondsema
    Dave Brondsema
    2013-03-07

    So, for this I think we should add radio buttons on the history view of a single file (not for whole directories) to diff between revisions. It could look like wiki page's revision history UI (e.g. https://sourceforge.net/p/allura/wiki/Allura%20Wiki/history). However, I'd like it a bit better than that: http://viget.org/Front_Page/_history/> uses just a single column of checkboxes so you don't have to worry about picking a backwards comparison. It's simpler and I like that. The color coding that it does is nice - if that's easy to do, include it too. Then submitting to form should take you to the existing diff controller.

     
  • Dave Brondsema
    Dave Brondsema
    2013-03-07

    • labels: support, p3 --> support, p3, 42cc
     

  • Anonymous
    2013-03-07

    Originally by: dcommander

    As an avid user of ViewVC, I would say that it's very important to minimize clicks in the new workflow, which is why I strongly recommend unifying this feature with the existing History page. When choosing revisions to diff, it's important to be able to see things like the commit date/time and log message. Please do not move this feature into a whole new page.

     
  • Dave Brondsema
    Dave Brondsema
    2013-03-07

    Yep, I was thinking the same thing -- add the checkboxes on the existing history view. You'll have to be drilled down to the history for an individual file though.

     

  • Anonymous
    2013-03-07

    Originally by: dcommander

    That's fine. That's the way ViewVC works.

     
    • status: open --> in-progress
     
  • Created #295: [#4929] better diff links between revisions (2cp)

     

    Related

    Tickets: #4929

    • status: in-progress --> code-review
     
  • Closed #295. allura:je/42cc_4929

     
  • Cory Johns
    Cory Johns
    2013-03-25

    • labels: support, p3, 42cc -->
    • status: code-review --> closed
    • qa: Cory Johns
    • milestone: forge-backlog --> forge-apr-05
     
  • Dave Brondsema
    Dave Brondsema
    2013-04-05

    • labels: --> 42cc, p3, support