#4977 code browser 500s on directories with '+' [ss649]

v1.0.0
closed
nobody
support (446) p3 (267) 42cc (432)
General
Dave Brondsema
2015-08-20
2012-09-19
Chris Tsai
No

[forge:site-support:#649]

eg. http://sourceforge.net/p/arpp/code/172/tree/trunk/activerecord%2B%2B/

Haven't tested other special characters, but I expect others may break this as well.

PS. I feel like this is a dupe, but I couldn't find one...

Related

Tickets: #4977

Discussion

  • Dave Brondsema

    Dave Brondsema - 2012-09-20
    • labels: support, p3 --> support, p3, 42cc
    • milestone: limbo --> forge-backlog
     

  • Igor Bondarenko - 2012-09-21

    Created #171: [#4977] code browser 500s on directories with '+' (1cp)

    • status: open --> in-progress
     

    Related

    Tickets: #4977

  • Igor Bondarenko - 2012-09-25

    Closed #171. Branch 42cc_4977.

    • status: in-progress --> code-review
     

  • Dave Brondsema

    Dave Brondsema - 2012-09-26

    Feedback (doesn't have to change this ticket, but for future):

    • "fixed bugs and added test" isn't a very helpful commit message. It'd be better to state what the bug or the functionality actually is
    • at some point we're going to separate the ForgeHg tool from the rest of Allura (due to GPL license), so it'd be better to add general tests like this to ForgeGit which will stay in the core codebase
     

  • Dave Brondsema

    Dave Brondsema - 2012-09-26
    • status: code-review --> closed
    • qa: Dave Brondsema
    • milestone: forge-backlog --> forge-oct-05
     

  • Igor Bondarenko - 2012-09-27

    Ok, we'll take this into account.

     

Log in to post a comment.