#5048 pagination links moved

v1.0.0
closed
nobody
42cc (416)
General
nobody
2015-08-20
2012-10-03
Dave Brondsema
No

The pagination links have shifted. One example: http://screencast.com/t/4Fabdqax1xgw I think I've seen this on multiple tools, including some where the pagination is at the top and bottom too.

Related

Tickets: #5048

Discussion

  • Dave Brondsema
    Dave Brondsema
    2012-10-03

    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1 @@
    -The pagination links have shifted.  One example: http://screencast.com/t/eyddu2Z94F  I think I've seen this on multiple tools, including some where the pagination is at the top and bottom too.
    +The pagination links have shifted.  One example: http://screencast.com/t/4Fabdqax1xgw  I think I've seen this on multiple tools, including some where the pagination is at the top and bottom too.
    
     
  • Dave Brondsema
    Dave Brondsema
    2012-10-05

    • size: --> 1
     
  • Dave Brondsema
    Dave Brondsema
    2012-10-11

    • labels: --> 42cc
     
    • status: open --> in-progress
     
  • Created #189: [#5048] pagination links moved (1cp)

     

    Related

    Tickets: #5048

  • We found out that the problem is caused by new version of EasyWidgets. When it compresses several widget's resources into one file, it separates them by semicolon. That CSS syntax seems to be invalid, so all styles that follow a semicolon are lost.

    E.g. for link like this:

    <link href="https://a.fsdn.com/allura/nf/1349976887/_ew_/_slim/css?href=css%2Fmarkitup_sf.css%3Bcss%2Fpage_list.css" type="text/css" rel="stylesheet">
    

    we have output like that:

    .markdown_edit textarea{
        height: 200px;
        width: 95%;
        font-family: Consolas, "Andale Mono", "Lucida Console", monospace;
    }
    .markdown_edit .btn{
        margin: 5px 5px 5px 0;
        display: inline-block;
    };
    .page_list {
        float: right;
        margin: 0 20px 20px 0;
        font-size: 1.1em;
    }
    

    (Notice the semicolon after closing brace)

    Last version of EasyWidgets that doesn't have this bug is EasyWidgets==0.2dev-20110726

    We're suggesting a possible fix for new EasyWidgets:

    diff --git a/resource.py b/resource1.py
    index e07cbb5..5bf2de0 100644
    --- a/resource.py
    +++ b/resource1.py
    @@ -179,7 +179,7 @@ class ResourceManager(object):
                     getter = get_min_css
                 except ImportError: # pragma no cover
                     pass
    -        content = ';\n'.join(getter(h) for h in href.split(';') )
    +        content = '\n'.join(getter(h) for h in href.split(';') )
             if self.use_cache:
                 self.resource_cache[href] = content
             return content
    
    • status: in-progress --> code-review
     
  • Closed #189.

     
  • Dave Brondsema
    Dave Brondsema
    2012-10-23

    • status: code-review --> closed
    • size: 1 --> 0
    • milestone: forge-nov-16 --> forge-nov-02