#5080 Check **kwargs on ming find() NEEDS RELEASE

v1.0.0
closed
Dave Brondsema
stability (19) sf-1 (616)
General
Cory Johns
2015-08-20
2012-10-06
Dave Brondsema
No

Ming's get() supports **kwargs but find() does not. Ensure that find() requires at least one positional arg for the criteria, rather than returning everything in the collection. Ming does a few checks like that already in other places.

Prevent https://engr.geek.net/git/?p=forge-classic.git;a=commitdiff;h=373110db792b11e0e5f82ded08c0c36e12b82a39 from recurring

Discussion

  • Dave Brondsema

    Dave Brondsema - 2012-10-30
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2012-10-30
    • status: in-progress --> code-review
    • qa: Cory Johns
     

  • Dave Brondsema

    Dave Brondsema - 2012-10-30

    merciless:db/5080 and allura:db/5080 After review, we need to cut a ming release and update it in req.txt

     

  • Cory Johns - 2012-10-31
    • summary: Check kwargs on ming find() --> Check kwargs on ming find() NEEDS RELEASE
    • status: code-review --> validation
     

  • Dave Brondsema

    Dave Brondsema - 2012-11-01
    • status: validation --> closed
     

  • Dave Brondsema

    Dave Brondsema - 2012-11-02
    • labels: --> stability
     

Log in to post a comment.