#5177 Better branch/commit logic when creating new merge requests

v1.0.1
closed
General
2015-08-20
2012-10-22
No

It's easy to create merge requests with the wrong branches & commits specified. It defaults both branch drop-downs to the first one alphabetically. It should default to master for git and default? for hg. Potentially look at the branches to see which one(s) have new commits, to be even smarter about the default options. There should be a warning or error if 0 commits are included in the request.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2013-03-19

    Wayne also suggested having the local branch default to the one you were just looking at.

     
  • Dave Brondsema

    Dave Brondsema - 2013-08-07
    • labels: merge-requests --> merge-requests, 42cc
     
  • Dave Brondsema

    Dave Brondsema - 2013-08-07

    Can use app.default_branch_name for the destination.

    We shouldn't have to do any fancy stuff like looking to see which branches have new commits.

     
  • Cory Johns - 2013-08-08
    • labels: merge-requests, 42cc --> merge-requests
    • status: open --> code-review
    • assigned_to: Cory Johns
    • Milestone: forge-backlog --> forge-aug-09
     
  • Cory Johns - 2013-08-08

    allura:cj/5177

     
  • Cory Johns - 2013-08-08
    • Size: --> 1
     
  • Dave Brondsema

    Dave Brondsema - 2013-08-12
    • status: code-review --> in-progress
     
  • Dave Brondsema

    Dave Brondsema - 2013-08-12

    Works well, but I'd be happier to see a test case, or enhancement to existing test_merge_request_* tests (e.g. something simple like following the link on the sidebar and check that the selected branch is correct)

     
  • Cory Johns - 2013-08-13
    • status: in-progress --> code-review
     
  • Cory Johns - 2013-08-13

    Force-pushed test case:
    allura:cj/5177

     
  • Dave Brondsema

    Dave Brondsema - 2013-08-13
    • status: code-review --> closed
    • QA: Dave Brondsema
     

Log in to post a comment.