#5339 Unable to remove attachment from comments [ss1627]

asf_release_1.0.0
closed
nobody
General
Cory Johns
2015-02-16
2012-11-21
Chris Tsai
No

[forge:site-support:#1627]

I can see a button with an X, but pushing that doesn't do anything.

Thanks in advance for fixing.

eg. attachment

Confirmed, tested with both FF and Chrome

Related

Tickets: #5339

Discussion

  • Dave Brondsema
    Dave Brondsema
    2012-12-12

    This could use a little CSS improvement too; the X isn't positioned very well.

     
  • Dave Brondsema
    Dave Brondsema
    2012-12-12

    • labels: support, p3 --> support, p3, 42cc
    • milestone: limbo --> forge-backlog
     
  • Created #239: [#5339] Unable to remove attachment from comments (1cp)

     

    Related

    Tickets: #5339

    • status: open --> in-progress
     
    • status: in-progress --> code-review
     
  • Closed #239.

    allura:42cc_5339

    Also changes in sftheme required.

    diff --git a/allura/sftheme/nf/sftheme/sass/partials/_attachment.scss b/allura/sftheme/nf/sftheme/sass/partials/_att
    index dca7ccc..4595427 100644
    --- a/allura/sftheme/nf/sftheme/sass/partials/_attachment.scss
    +++ b/allura/sftheme/nf/sftheme/sass/partials/_attachment.scss
    @@ -1,16 +1,25 @@
     .attachment_images{
         overflow: auto;
     }
    +input.submit{
    +    &.delete_attachment{
    +        &.pic{
    +            position: absolute;
    +            top: 0;
    +            left: 100px;
    +        }
    +        &.file{
    +            position: absolute;
    +            top: 0;
    +            right: -40px;
    +        }
    +    }
    +}
     div.attachment_thumb{
         float: left;
         margin: .5em;
         position: relative;
         padding: 10px;
    -    .delete_attachment{
    -        position: absolute;
    -        top: 0;
    -        left: 100px;
    -    }
         .file_type{
             border: 1px solid #ccc;
             display: block;
    
     
  • Cory Johns
    Cory Johns
    2013-01-07

    • status: code-review --> closed
    • qa: Cory Johns
    • milestone: forge-backlog --> forge-jan-11