Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, deshani, dill0wn, and 10 others

#5358 News import breaks links with underscore

Milestone: v1.0.0

Status: closed

Owner: Dave Brondsema

Labels: phpmyadmin (2) migration (63) sf-2 (994)

Component: General

Reviewer: Tim Van Steenburgh

Updated: 2015-08-20

Created: 2012-11-28

Creator: Anonymous

Private: No

Originally created by: nijel

News import breaks links with underscore by escaping them. For example the correct link http://www.phpmyadmin.net/home_page/security/ will be turned into http://www.phpmyadmin.net/home_page/security/

Discussion

Dave Brondsema - 2012-11-30

milestone: limbo --> forge-dec-14
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2012-11-30

We could fix from either the conversion side (the escape isn't strictly necessary here; need to add precise escaping rules into html2text) or on the rendering side (an escape shouldn't have to disrupt the autolink)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2012-12-14

labels: phpmyadmin --> phpmyadmin, migration
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2012-12-14

milestone: forge-dec-14 --> forge-jan-11
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-01-03

Milestone: forge-jan-11 --> forge-jan-25
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-01-11

size: --> 2
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-01-25

Milestone: forge-jan-25 --> forge-feb-08
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-02-04

status: open --> in-progress

assigned_to: Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-02-08

Milestone: forge-feb-08 --> forge-feb-22
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-02-13

status: in-progress --> code-review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-02-13

allura:db/5358 Try to think of a way this can break. I'd rather not have it bypass some escaping, but I believe it is still safe.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2013-02-18

qa: Tim Van Steenburgh
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2013-02-18

status: code-review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-02-20

status: closed --> open
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-02-20

This needs further work - it breaks links like [text](http://example.com)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-02-21

I think this should be a Preprocessor that wraps the URL with <> chars (which have no problem containing escaped chars), instead of inline pattern. That should clean up the escaping issues.

Probably doesn't help the breakage situation though.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-02-21

Preprocessor doesn't work because it won't know the URL is inside of a literal or pre-formatted block.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-02-21

status: open --> code-review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-02-21

allura:db/5358b

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2013-02-21

labels: phpmyadmin, migration -->

status: code-review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-02-21

labels: --> phpmyadmin, migration
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.