#5358 News import breaks links with underscore

v1.0.0
closed
General
2015-08-20
2012-11-28
Anonymous
No

Originally created by: nijel

News import breaks links with underscore by escaping them. For example the correct link http://www.phpmyadmin.net/home_page/security/ will be turned into http://www.phpmyadmin.net/home_page/security/

Discussion

  • Dave Brondsema

    Dave Brondsema - 2012-11-30
    • milestone: limbo --> forge-dec-14
     
  • Dave Brondsema

    Dave Brondsema - 2012-11-30

    We could fix from either the conversion side (the escape isn't strictly necessary here; need to add precise escaping rules into html2text) or on the rendering side (an escape shouldn't have to disrupt the autolink)

     
  • Dave Brondsema

    Dave Brondsema - 2012-12-14
    • labels: phpmyadmin --> phpmyadmin, migration
     
  • Dave Brondsema

    Dave Brondsema - 2012-12-14
    • milestone: forge-dec-14 --> forge-jan-11
     
  • Dave Brondsema

    Dave Brondsema - 2013-01-03
    • Milestone: forge-jan-11 --> forge-jan-25
     
  • Dave Brondsema

    Dave Brondsema - 2013-01-11
    • size: --> 2
     
  • Dave Brondsema

    Dave Brondsema - 2013-01-25
    • Milestone: forge-jan-25 --> forge-feb-08
     
  • Dave Brondsema

    Dave Brondsema - 2013-02-04
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2013-02-08
    • Milestone: forge-feb-08 --> forge-feb-22
     
  • Dave Brondsema

    Dave Brondsema - 2013-02-13
    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2013-02-13

    allura:db/5358 Try to think of a way this can break. I'd rather not have it bypass some escaping, but I believe it is still safe.

     
  • Tim Van Steenburgh

    • qa: Tim Van Steenburgh
     
  • Tim Van Steenburgh

    • status: code-review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2013-02-20
    • status: closed --> open
     
  • Dave Brondsema

    Dave Brondsema - 2013-02-20

    This needs further work - it breaks links like [text](http://example.com)

     
  • Dave Brondsema

    Dave Brondsema - 2013-02-21

    I think this should be a Preprocessor that wraps the URL with <> chars (which have no problem containing escaped chars), instead of inline pattern. That should clean up the escaping issues.

    Probably doesn't help the breakage situation though.

     
  • Dave Brondsema

    Dave Brondsema - 2013-02-21

    Preprocessor doesn't work because it won't know the URL is inside of a literal or pre-formatted block.

     
  • Dave Brondsema

    Dave Brondsema - 2013-02-21
    • status: open --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2013-02-21

    allura:db/5358b

     
  • Tim Van Steenburgh

    • labels: phpmyadmin, migration -->
    • status: code-review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2013-02-21
    • labels: --> phpmyadmin, migration
     

Log in to post a comment.