Apache Allura™

Originally by: dcommander

See also https://sourceforge.net/p/allura/tickets/4929/, regarding enabling the Allura code viewer to diff between any two arbitrary revisions in the history view, as ViewVC did.

• milestone: limbo --> forge-backlog

There's definitely room to show the full commit message and full date/time. I'm not sure about dispaying it in a fixed-width font since we should be supporting Markdown rendering of commit message text.

Additional links and showing byte size seem a little less valuable in my opinion, but if we can add them without making the listing too cluttered it should be fine.

Originally by: dcommander

Personally, I don't care how cluttered it is as long as it's as usable as ViewVC. Currently it ain't. The history view is the most important view, and a lot of developers are used to the workflow of ViewVC-- of being able to pull up a history view of a file from the directory view, then see at a glance how the file has evolved, diff between revisions, download or view the file, or see its origins (whether it was copied from another file, etc.) Without this functionality, the new code viewer is a regression relative to ViewVC.

For git & hg, showing tags would be nice too.

• labels: --> feature-parity, 42cc

• status: open --> in-progress

Created #314: [#5773] Allura Code Viewer: provide more information in History view (3 cp)

• status: in-progress --> code-review

Closed #314.

Allura: je/42cc_5773
ForgeHg: 42cc_5773 (just minor changes in tests)

• QA: Dave Brondsema

• status: code-review --> in-progress

• SVN repos show timestamps with microseconds which isn't necessary (and takes up precious room)
• I'd drop the grid-14 within the first td. This will remove some unnecessary whitespace on the left side, and will also give the whole table the flexibility to adjust width. Then the timestamp won't always wrap.
• .pad p has a padding: 0 10px 1em; rule which is adding whitespace to the left & below the commit message. That makes the left side not lined up well, and wasted space between each commit. I don't know exactly what the right fix is, perhaps just override that CSS rule with a more specific one.
• when a commit is pushed by someone other than the author, the consistency of our attributions is broken. Let's flip it so we always have the git hash & author first. E.g. " [5fb61a] by Julien Danjou, pushed by Rick Copeland". BTW, I do like how you put this line above the commit message. That makes a lot of sense.
• Use c.app.repo.url_for_commit instead of constructing the symbolic link URLs in the template. That'll ensure special characters are handled.
• with mercurial, the 'tip' symbolic link goes to .../ci/tip/treeNone which is wrong. Maybe that'll get fixed by using url_for_commit?

Created #328: [#5773] Code viewer improvements (1cp)

• status: in-progress --> code-review

Closed #328.

Allura: je/42cc_5773
ForgeHg: 42cc_5773

sftheme:

diff --git allura/sftheme/nf/sftheme/sass/partials/_base.scss allura/sftheme/nf/sftheme/sass/partials/_base.scss
index fc1ff99..06507eb 100644
--- allura/sftheme/nf/sftheme/sass/partials/_base.scss
+++ allura/sftheme/nf/sftheme/sass/partials/_base.scss
@@ -49,6 +49,14 @@
 div.markdown_preview{
   display: block;
 }
+tr.rev{
+  div.markdown_content{
+    p{
+      padding: 0;
+      margin-bottom: 0;
+    }
+  }
+}
 div.reply{
   div.markdown_preview{
     margin-right: 0;

• status: code-review --> validation
• Milestone: forge-backlog --> forge-may-03

• Milestone: forge-may-03 --> forge-may-17

• status: validation --> closed