#5861 Anchored tools shouldn't install something twice

v1.0.0
closed
nobody
General
2015-08-20
2013-02-21
No

If you set up a neighborhood's anchored tools to wiki:Wiki and then register a new project and mark the checkbox for a wiki, you end up with 2 wikis on your project and also the following error in the logs.

The anchored tool logic works pretty well for existing projects -- when you set the anchored tools and a project already has one, it doesn't install another. This should work similarly during project registration too.

16:26:48,868 ERROR [allura.model.project] wiki is not available
Traceback (most recent call last):
  File "/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/model/project.py", line 453, in install_anchored_tools
    new_tools.append(self.install_app(tool, tool, label, i))
  File "/home/dbrondsema/dbrondsema-7024/forge/Allura/allura/model/project.py", line 544, in install_app
    'Mount point "%s" is already in use' % mount_point)
ToolError: Mount point "wiki" is already in use

Related

Tickets: #5861

Discussion

  • Dave Brondsema

    Dave Brondsema - 2013-02-21
    • labels: 42cc --> 42cc, projectnav
     
  • Igor Bondarenko - 2013-02-22

    Created #284: [#5861] Anchored tools shouldn't install something twice (1cp)

     

    Related

    Tickets: #5861

  • Igor Bondarenko - 2013-02-22
    • status: open --> in-progress
     
  • Igor Bondarenko - 2013-03-06
    • status: in-progress --> code-review
     
  • Igor Bondarenko - 2013-03-06

    Closed #284. allura:je/42cc_5861

    Also, we've fixed a bug in the nav grouping.

    You can reproduce the bug on master as follows:

    • when creating a project, check several kinds of repo to install initially (e.g. 'Git' and 'Mercurial')
    • you'll end up with 'Git' and 'Mercurial' installed, but in the top nav you'll see only one of them.
     
  • Dave Brondsema

    Dave Brondsema - 2013-03-06
    • qa: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2013-03-06
    • status: code-review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2013-03-06
    • milestone: forge-backlog --> forge-mar-08
     

Log in to post a comment.