#5891 Can't add attachments to replies in our Allura system on SF [ss2926]
closed
nobody
General
2015-08-20
2013-02-26
No
[forge:site-support:#2926]
Users are attaching files, e-mails mention the attachment, but no attachment shows up. See: https://sourceforge.net/p/taskcoach/support-requests/332/
After a bit of testing, it looks like the issue is related to whether the comment is made via a "reply" to a comment (doesn't work), or via the comment form at the bottom (works).
Interestingly, if you edit a reply, and attach upon edit, it shows up after that.
Created #316: [#5891] Can't add attachments to replies (2cp)
Related
Tickets:
#5891Closed #316.
je/42cc_5891This works well, but we shouldn't be duplicating code. The 9 lines look the same as those in
def attach(). A shared helper method could be nice. Moreover, there are two other places inAllura/allura/controllers/discuss.pythat haveif hasattr(file_info, 'file')but no mime type handling. Take a look at those and see if those should have the mime type handling too, and then they can all be refactored.Created #327: [#5891] Refactoring for comments attachments (1cp)
Related
Tickets:
#5891Closed #327. All changes in
je/42cc_5891