#5891 Can't add attachments to replies in our Allura system on SF [ss2926]

asf_release_1.0.0
closed
nobody
General
2014-11-22
2013-02-26
Chris Tsai
No

[forge:site-support:#2926]

Users are attaching files, e-mails mention the attachment, but no attachment shows up. See: https://sourceforge.net/p/taskcoach/support-requests/332/

After a bit of testing, it looks like the issue is related to whether the comment is made via a "reply" to a comment (doesn't work), or via the comment form at the bottom (works).

Related

Tickets: #5731
Tickets: #5891

Discussion


  • Chris Tsai
    2013-02-26

    Interestingly, if you edit a reply, and attach upon edit, it shows up after that.

     
  • Dave Brondsema
    Dave Brondsema
    2013-04-11

    • labels: support, p3 --> support, p3, 42cc
    • Milestone: limbo --> forge-backlog
     
  • Created #316: [#5891] Can't add attachments to replies (2cp)

     

    Related

    Tickets: #5891

    • status: open --> in-progress
     
    • status: in-progress --> code-review
     
  • Closed #316. je/42cc_5891

     
  • Dave Brondsema
    Dave Brondsema
    2013-04-26

    • QA: Dave Brondsema
     
  • Dave Brondsema
    Dave Brondsema
    2013-04-26

    • status: code-review --> in-progress
     
  • Dave Brondsema
    Dave Brondsema
    2013-04-26

    This works well, but we shouldn't be duplicating code. The 9 lines look the same as those in def attach(). A shared helper method could be nice. Moreover, there are two other places in Allura/allura/controllers/discuss.py that have if hasattr(file_info, 'file') but no mime type handling. Take a look at those and see if those should have the mime type handling too, and then they can all be refactored.

     
  • Created #327: [#5891] Refactoring for comments attachments (1cp)

     

    Related

    Tickets: #5891

  • Closed #327. All changes in je/42cc_5891

     
    • status: in-progress --> code-review
     
  • Dave Brondsema
    Dave Brondsema
    2013-04-30

    • status: code-review --> closed
    • Milestone: forge-backlog --> forge-may-03