Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, deshani, dill0wn, and 10 others

#5978 guess_repo too slow on Allura repo

Milestone: v1.0.0

Status: closed

Owner: Cory Johns

Labels: performance (126) sf-2 (994)

Component: General

Reviewer: Dave Brondsema

Updated: 2015-08-20

Created: 2013-03-18

Creator: Dave Brondsema

Private: No

https://sourceforge.net/p/allura/pastebin/514771f57929e5773688e6e4

Probably could cache the first result, and make it a bit smarter too (e.g. can we instantiate only scm apps?)

Discussion

Dave Brondsema - 2013-03-22

size: --> 2
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-03-26

status: open --> in-progress

assigned_to: Cory Johns
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-03-26

status: in-progress --> code-review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-03-26

allura:cj/5978

It turns out that guess_repo is already cached in the two places it's called, and I didn't want to hard-code tool-names to identify SCM apps (we probably need some way to identify "types" of tools).

However, guess_repo shouldn't have been being called at all, so I fixed that (missing call to set_context) so it should be much faster now.

To test, view any SCM tree with stats logging enabled (1) and see that guess_repo no longer shows up in the stats.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-03-28

qa: Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-03-28

status: code-review --> in-progress
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-03-28

Couldn't duplicate guess_repo being called on a tree view, but it is called a lot on a log view.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-03-28

Fix for History view and logging any other calls pushed.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2013-03-28

status: in-progress --> code-review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2013-03-29

status: code-review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.