#6105 Refactor markdown macros to use jinja2 templates instead of string.Template

v1.0.0
closed
nobody
42cc (432)
General
Tim Van Steenburgh
2015-08-20
2013-04-15
Cory Johns
No

In allura/lib/macro.py, several of the macros use string.Template() with HTML in the python code. This should be refactored to use jinja2 and external .html files, to get proper escaping of interpolated values and separation of HTML and python.

Related

Tickets: #6105

Discussion

  • Dave Brondsema

    Dave Brondsema - 2013-04-22
    • labels: --> 42cc
     

  • Igor Bondarenko - 2013-04-23
    • status: open --> in-progress
     

  • Igor Bondarenko - 2013-04-23

    Created #321: [#6105] Refactor markdown macros to use jinja2 templates instead of string.Template (1cp)

     

    Related

    Tickets: #6105

  • Igor Bondarenko - 2013-04-29

    Closed #321. je/42cc_6105

     

  • Igor Bondarenko - 2013-04-29
    • status: in-progress --> code-review
     

  • Dave Brondsema

    Dave Brondsema - 2013-05-03
    • status: code-review --> in-progress
     

  • Dave Brondsema

    Dave Brondsema - 2013-05-03

    The jinja2.escape calls in macro.py shouldn't be necessary any more. Remove and confirm that the templates escape everything automatically.

     

  • Igor Bondarenko - 2013-05-06

    Created #348: [#6105] Followup to Refactor markdown macros (1cp)

     

    Related

    Tickets: #6105

  • Igor Bondarenko - 2013-05-08
    • status: in-progress --> code-review
     

  • Igor Bondarenko - 2013-05-08

    Closed #348. je/42cc_6105 (forced update)

     

  • Tim Van Steenburgh - 2013-05-23
    • QA: Tim Van Steenburgh
    • Milestone: forge-backlog --> forge-may-31
     

  • Tim Van Steenburgh - 2013-05-23
    • status: code-review --> closed
     

Log in to post a comment.