#6138 standardize case on GA custom tool type NEEDS MONGO CMD

v1.0.0
closed
sf-1 (616)
General
2015-08-20
2013-04-18
No

Top GA custom events are:

Discussion
Wiki
Tickets
blog
SVN
wiki
Git
git
profile
Blog

We need to stop having two capitalizations for blog and git, maybe more. We should use the most popular (e.g. don't just lowercase, that'd cause disconnect with historical values for e.g. Discussion)

IIRC there is GA code in both sftheme and the OSS template. OSS template doesn't need to be changed, just ours, since this is a problem of old app configs.

Or change old app configs in prod, to be consistent?

See also [#3981] which will track this internally

Related

Tickets: #6195

Discussion

  • Dave Brondsema

    Dave Brondsema - 2013-04-18
    • Milestone: forge-apr-19 --> forge-may-03
     
  • Dave Brondsema

    Dave Brondsema - 2013-04-19
    • Size: --> 1
     
  • Dave Brondsema

    Dave Brondsema - 2013-04-19

    Best to update mongo

     
  • Cory Johns - 2013-04-29
    • status: open --> in-progress
    • assigned_to: Cory Johns
     
  • Cory Johns - 2013-04-29

    sftheme:cj/6138

    Went with lower-case because 61% of the tool_name values are all lower-case in production.

     
  • Cory Johns - 2013-04-29
    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2013-04-30
    • QA: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2013-04-30

    I thought we were going to change the values in prod

     
  • Dave Brondsema

    Dave Brondsema - 2013-04-30
    • status: code-review --> in-progress
     
  • Cory Johns - 2013-05-01

    allura:cj/6138
    https://sourceforge.net/p/allura/pastebin/51818ea7a02bb1761ab804e6/

    Code change to enforce new AppConfigs are created with lower-case tool_names, query to update existing entries.

     
  • Cory Johns - 2013-05-01
    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2013-05-02
    • summary: standardize case on GA custom tool type --> standardize case on GA custom tool type NEEDS MONGO CMD
    • status: code-review --> validation
    • private: Yes --> No
     
  • Dave Brondsema

    Dave Brondsema - 2013-05-02

    Merged allura; didn't merge sftheme since it's not needed with the mongo approach.

     
  • Dave Brondsema

    Dave Brondsema - 2013-05-03

    Better to not change the names to lowercase all over the place, but use the entry point name in install_app (not what's passed in as a param) so the saved data is consistent within each tool.

    Mongo commands to update individual tools will be needed too.

     
  • Dave Brondsema

    Dave Brondsema - 2013-05-03
    • status: validation --> open
     
  • Dave Brondsema

    Dave Brondsema - 2013-05-03
    • Milestone: forge-may-03 --> forge-may-17
     
  • Cory Johns - 2013-05-06
    • status: open --> code-review
     
  • Cory Johns - 2013-05-06

    allura:cj/6138

    After discussing with Tim, went back to the approach of lower-casing the tool_name value on the app_config but changed it to use the defined value from the app for the grouping label so it displays properly but is nicely standardized in mongo.

     
  • Cory Johns - 2013-05-06

    Normalizing mongo to use the app-defined tool_label value would be a lot more complicated, harder to remember when querying, and still wouldn't fix the display of the grouped tools because of it calling tool_name.lower().capitalize() (essentially).

     
  • Dave Brondsema

    Dave Brondsema - 2013-05-07
    • status: code-review --> validation
     
  • Dave Brondsema

    Dave Brondsema - 2013-05-07
    • status: validation --> closed
     

Log in to post a comment.