#6195 Remove capitalize() calls in menu handling

v1.0.0
closed
Cory Johns
projectnav (7) sf-2 (994)
General
Dave Brondsema
2015-08-20
2013-05-02
Dave Brondsema
No

Followup to [#3699]

capitalize is used in a few places on tool names, and it shouldn't. Example result, SVN is fine but CVS is not: https://sourceforge.net/p/javapathfinder/cvs/

I think tool type is being used instead of tool label in some cases during grouping. E.g. hosted_apps shows in some menus.

Related

Tickets: #3699

Discussion

  • Dave Brondsema

    Dave Brondsema - 2013-05-03
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,3 +1,5 @@
 Followup to [#3699]

 `capitalize` is used in a few places on tool names, and it shouldn't.  Example result, SVN is fine but CVS is not: https://sourceforge.net/p/javapathfinder/cvs/
+
+I think tool type is being used instead of tool label in some cases during grouping.  E.g. `hosted_apps` shows in some menus.
    • Size: --> 2
     

    Related

    Tickets: #3699

  • Dave Brondsema

    Dave Brondsema - 2013-05-03
    • Milestone: forge-may-17 --> forge-may-31
     

  • Cory Johns - 2013-05-07
    • status: open --> code-review
    • assigned_to: Cory Johns
     

  • Cory Johns - 2013-05-07

    I believe this is done in [#6138] though I will do an additional grep to be sure.

     

    Related

    Tickets: #6138

  • Cory Johns - 2013-05-07
    • status: code-review --> in-progress
     

  • Cory Johns - 2013-05-07
    • status: in-progress --> code-review
     

  • Cory Johns - 2013-05-07

    allura:cj/6195
    forge-classic:cj/6195

     

  • Tim Van Steenburgh - 2013-05-08
    • QA: Tim Van Steenburgh
     

  • Tim Van Steenburgh - 2013-05-08

    This is all good except for:

    diff --git a/sfx/lib/migrate.py b/sfx/lib/migrate.py
index e63fa24..055de51 100644
--- a/sfx/lib/migrate.py
+++ b/sfx/lib/migrate.py
@@ -1727,7 +1727,7 @@ class SCMMigrator(object):
                     (len(repos) > 1 and name == self.project.shortname):
                 if (name_taken and type_counts[typ] > 1) or mount_taken:
                     new_name = '{0}-{1}'.format(name, typ)
-                    new_label = '{0} {1}'.format(name.title(), typ_label)
+                    new_label = '{0} {1}'.format(name, typ_label)

    That change, and the resulting test changes, should be reverted. In the case where we have to rename a migrating repo, it looks better to use title case.

     

  • Tim Van Steenburgh - 2013-05-08
    • status: code-review --> in-progress
     

  • Cory Johns - 2013-05-08

    Force-pushed forge-classic

     

  • Cory Johns - 2013-05-08
    • status: in-progress --> code-review
     

  • Dave Brondsema

    Dave Brondsema - 2013-05-14
    • QA: Tim Van Steenburgh --> Dave Brondsema
    • Milestone: forge-may-31 --> forge-may-17
     

  • Dave Brondsema

    Dave Brondsema - 2013-05-14
    • status: code-review --> closed
     

Log in to post a comment.