#6211 widget template shouldn't extend g.theme.master

v1.0.0
closed
nobody
General
2015-08-20
2013-05-07
No

allura/templates/discussion/index.html isn't a full template that extends g.theme.master ON forum browse pages, it eventually calls forgediscussion/templates/discussion_widgets/discussion.html which is a widget template but does extend g.theme.master That is non-standard and has the effect of template globals (like config) not being present within the custom_js theme macro.

We should see if these templates (and any other related ones) can be made more standard, to avoid such issues.

Related

Tickets: #6211

Discussion

  • Dave Brondsema

    Dave Brondsema - 2013-05-17
    • Milestone: forge-may-17 --> forge-may-31
     
  • Dave Brondsema

    Dave Brondsema - 2013-05-20
    • Size: --> 2
     
  • Dave Brondsema

    Dave Brondsema - 2013-05-20
    • Milestone: forge-may-31 --> forge-jun-06
     
  • Dave Brondsema

    Dave Brondsema - 2013-05-22
    • labels: stability --> stability, 42cc
    • Size: 2 --> 0
    • Milestone: forge-jun-06 --> forge-backlog
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-05-23

    Created #364: [#6211] widget template shouldn't extend g.theme.master (2cp)

     

    Related

    Tickets: #6211

  • Igor Bondarenko

    Igor Bondarenko - 2013-05-23
    • status: open --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-06-19
    • status: in-progress --> code-review
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-06-19

    Closed #364. je/42cc_6211

     
  • Dave Brondsema

    Dave Brondsema - 2013-07-01
    • QA: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2013-07-01
    • status: code-review --> closed
    • Milestone: forge-backlog --> forge-jul-12
     

Log in to post a comment.