#6222 merge requests break on log display of symbolics_for_commit

v1.0.0
closed
nobody
General
Cory Johns
2015-08-20
2013-05-08
No

Getting this on every merge request that has commits to show.

Make sure you add a test for this, since apparently we don't have a realistic functional test of a merge request page.

File '/var/local/allura/Allura/allura/templates/repo/merge_request.html', line 43 in block "content"
  {{ c.log_widget.display(value=req.commits) }}
File '/var/local/env-allura/lib/python2.7/site-packages/EasyWidgets-0.2dev_20130116-py2.7.egg/ew/widget.py', line 45 in display
  return self.template(context)
File '/var/local/env-allura/lib/python2.7/site-packages/EasyWidgets-0.2dev_20130116-py2.7.egg/ew/render.py', line 32 in __call__
  return self.engine.render(self.template, context)
File '/var/local/allura/Allura/allura/config/app_cfg.py', line 129 in render
  text = template.render(**context)
File '/var/local/env-allura/lib/python2.7/site-packages/TimerMiddleware-0.4.2-py2.7.egg/timermiddleware/__init__.py', line 116 in wrapper
  return self.run_and_log(func, inst, *args, **kwargs)
File '/var/local/env-allura/lib/python2.7/site-packages/TimerMiddleware-0.4.2-py2.7.egg/timermiddleware/__init__.py', line 125 in run_and_log
  return func(*args, **kwargs)
File '/var/local/env-allura/lib/python2.7/site-packages/Jinja2-2.6-py2.7.egg/jinja2/environment.py', line 894 in render
  return self.environment.handle_exception(exc_info, True)
File '/var/local/allura/Allura/allura/templates/widgets/repo/log.html', line 41 in top-level template code
  {% if c.app.repo.symbolics_for_commit(commit)[1] %}
File '/var/local/allura/Allura/allura/model/repository.py', line 315 in symbolics_for_commit
  return self._impl.symbolics_for_commit(commit)
File '/var/local/env-allura/lib/python2.7/site-packages/TimerMiddleware-0.4.2-py2.7.egg/timermiddleware/__init__.py', line 116 in wrapper
  return self.run_and_log(func, inst, *args, **kwargs)
File '/var/local/env-allura/lib/python2.7/site-packages/TimerMiddleware-0.4.2-py2.7.egg/timermiddleware/__init__.py', line 125 in run_and_log
  return func(*args, **kwargs)
File '/var/local/allura/ForgeGit/forgegit/model/git_repo.py', line 335 in symbolics_for_commit
  containing_branches = self._git.git.branch(contains=commit._id)
File '/var/local/env-allura/lib/python2.7/site-packages/GitPython-0.3.2.RC1_20130424-py2.7.egg/git/cmd.py', line 227 in <lambda>
  return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
File '/var/local/env-allura/lib/python2.7/site-packages/GitPython-0.3.2.RC1_20130424-py2.7.egg/git/cmd.py', line 456 in _call_process
  return self.execute(call, **_kwargs)
File '/var/local/env-allura/lib/python2.7/site-packages/GitPython-0.3.2.RC1_20130424-py2.7.egg/git/cmd.py', line 377 in execute
  raise GitCommandError(command, status, stderr_value)
GitCommandError: 'git branch --contains=ff1a89a121c7aba721aaa8c639a3112f1788673e' returned exit status 129: error: no such commit ff1a89a121c7aba721aaa8c639a3112f1788673e

Related

Tickets: #6222
Tickets: #6239

Discussion

  • Igor Bondarenko

    Igor Bondarenko - 2013-05-09
    • status: open --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-05-09

    Created #349: [#6222] merge requests break on log display of symbolics_for_commit (3cp)

     

    Related

    Tickets: #6222

  • Igor Bondarenko

    Igor Bondarenko - 2013-05-10
    • status: in-progress --> code-review
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-05-10

    Closed #349. je/42cc_6222

     
  • Cory Johns

    Cory Johns - 2013-05-10
    • QA: Cory Johns
     
  • Cory Johns

    Cory Johns - 2013-05-10
    • status: code-review --> closed
    • Milestone: forge-backlog --> forge-may-17
     

Log in to post a comment.