#6284 Allura Code Viewer: show SVN revision in commit browser

v1.0.1
closed
nobody
42cc (433)
SCM
2015-08-20
2013-05-28
Anonymous
No

Originally created by: dcommander

This is another shortcoming of the new code viewer relative to ViewVC, and one that should be simple to address. When browsing the commits on a subversion repository, nowhere does it show you the revision number for the commit you are currently browsing-- although it does show you the parent and child revisions, if applicable.

Related

Tickets: #6284
Tickets: #6466

Discussion

  • Dave Brondsema

    Dave Brondsema - 2013-08-07
    • labels: --> 42cc
    • Milestone: limbo --> forge-backlog
     
  • Anton Kasyanov

    Anton Kasyanov - 2013-08-13

    Created #418 [#6284] Allura Code Viewer: show SVN revision in commit browser (2cp)

     

    Related

    Tickets: #6284

  • Anton Kasyanov

    Anton Kasyanov - 2013-08-13
    • status: open --> in-progress
     
  • Anton Kasyanov

    Anton Kasyanov - 2013-08-16

    I'm not sure if we have to add revision numbers to commits on canvas or only to the current commit somewhere above the commit message?

     
  • Dave Brondsema

    Dave Brondsema - 2013-08-16

    It should go into the canvas, so that you can see all the revisions for all the commits, at a glance. Once it's there, I don't think we need to put it anywhere else.

    Note this will affect git & hg too. Make sure you use the short-form of their commit ids.

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2013-08-16

    Originally by: dcommander

    Can you clarify what the canvas is, for those of us who are not Allura developers? This is a very simple issue. Go to the commit browser (say, https://sourceforge.net/p/libjpeg-turbo/code/commit_browser). Click on any commit. It shows the commit message in big blue text, but nowhere is the revision number shown. For maximum usability, it should really show the revision numbers both in the browser portion of the window (the top part) and in the big blue text area. That way, you could see the revision numbers at a glance, in case you needed to find a commit by number instead of by name, and you could also know for sure which revision number you're looking at currently.

     
  • Tim Van Steenburgh

    The canvas is the part you referred to as "the browser portion" (it's rendered on an html <canvas> element).

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2013-08-16

    Originally by: dcommander

    That makes sense. Yeah, if the rev. number is there, then you can tell which rev. you're looking at because it is highlighted, and thus it wouldn't be important for it to appear in the blue area.

     
  • Anton Kasyanov

    Anton Kasyanov - 2013-08-26
    • status: in-progress --> code-review
     
  • Anton Kasyanov

    Anton Kasyanov - 2013-08-26

    Closed #418 [#6284] Allura Code Viewer: show SVN revision in commit browser, branch 42cc_6284

     

    Related

    Tickets: #6284

  • Dave Brondsema

    Dave Brondsema - 2013-08-26
    • status: code-review --> validation
    • QA: Dave Brondsema
    • Milestone: forge-backlog --> forge-sep-06
     
  • Dave Brondsema

    Dave Brondsema - 2013-08-26

    Made a few minor cosmetic changes which are on the master branch now. Also made a test update in the forgehg repo.

    DRC: this will go live to SF.net in our next code push (probably this week)

     
  • Dave Brondsema

    Dave Brondsema - 2013-08-29
    • status: validation --> closed