Finish reviewing and merge MR#4
allura:cj/6325
c9192e6d adds 'mako' for no apparent reason.
Docstrings are great; we should add a pointer from our narrative docs and/or expose a few of the most important docstrings in our autogenerated api docs, so that people can easily find out how to implement their own override.
http://www.bitformation.com/art/python_toposort.html at the bottom has a license that requires a specific attribution.
And:
FAIL: allura.tests.unit.test_package_path_loader:TestPackagePathLoader.test_get_source vim +189 allura/tests/unit/test_package_path_loader.py # test_get_source rf.assert_called_once_with('allura.ext.admin', 'templates/audit.html') vim +873 /var/local/env-allura/lib/python2.7/site-packages/mock.py # assert_called_once_with raise AssertionError(msg) AssertionError: Expected to be called once. Called 0 times.
Thanks, I missed the attribution.
I assumed mako was added in case third-party apps wanted to use it. Is there a compelling reason to remove it?
You have to upgrade mock to 1.0.1.
Attribution and doc fixes force-pushed to:
Log in to post a comment.
allura:cj/6325c9192e6d adds 'mako' for no apparent reason.
Docstrings are great; we should add a pointer from our narrative docs and/or expose a few of the most important docstrings in our autogenerated api docs, so that people can easily find out how to implement their own override.
http://www.bitformation.com/art/python_toposort.html at the bottom has a license that requires a specific attribution.
And:
Thanks, I missed the attribution.
I assumed mako was added in case third-party apps wanted to use it. Is there a compelling reason to remove it?
You have to upgrade mock to 1.0.1.
Attribution and doc fixes force-pushed to:
allura:cj/6325