#6325 Finish merge-request #4

v1.0.0
closed
sf-1 (616)
General
2015-08-20
2013-06-03
Cory Johns
No

Finish reviewing and merge MR#4

Discussion

  • Cory Johns

    Cory Johns - 2013-06-03
    • status: open --> code-review
     
  • Cory Johns

    Cory Johns - 2013-06-03

    allura:cj/6325

     
  • Dave Brondsema

    Dave Brondsema - 2013-06-04
    • QA: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2013-06-04
    • status: code-review --> in-progress
     
  • Dave Brondsema

    Dave Brondsema - 2013-06-04

    c9192e6d adds 'mako' for no apparent reason.

    Docstrings are great; we should add a pointer from our narrative docs and/or expose a few of the most important docstrings in our autogenerated api docs, so that people can easily find out how to implement their own override.

    http://www.bitformation.com/art/python_toposort.html at the bottom has a license that requires a specific attribution.

     
  • Dave Brondsema

    Dave Brondsema - 2013-06-04

    And:

    FAIL: allura.tests.unit.test_package_path_loader:TestPackagePathLoader.test_get_source
      vim +189 allura/tests/unit/test_package_path_loader.py  # test_get_source
        rf.assert_called_once_with('allura.ext.admin', 'templates/audit.html')
      vim +873 /var/local/env-allura/lib/python2.7/site-packages/mock.py  # assert_called_once_with
        raise AssertionError(msg)
    AssertionError: Expected to be called once. Called 0 times.
    
     
  • Cory Johns

    Cory Johns - 2013-06-04

    Thanks, I missed the attribution.

    I assumed mako was added in case third-party apps wanted to use it. Is there a compelling reason to remove it?

     
  • Cory Johns

    Cory Johns - 2013-06-04

    You have to upgrade mock to 1.0.1.

     
  • Cory Johns

    Cory Johns - 2013-06-04

    Attribution and doc fixes force-pushed to:

    allura:cj/6325

     
  • Cory Johns

    Cory Johns - 2013-06-04
    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2013-06-06
    • status: code-review --> closed
     

Log in to post a comment.