#6391 Provide default `sitemap` in base Application class

v1.0.0
closed
sf-1 (616)
General
2015-08-20
2013-06-25
No

From IRC:

tvansteenburgh
I would like to add this to the Application base class:

@property
def sitemap(self):
    return [SitemapEntry(self.config.options.mount_label, '.')]

There's no reason for Application to not implement this default.
Otherwise, subclasses need to provide sitemap just to get the tool to show up in the nav.

Related

Tickets: #1599

Discussion

  • Tim Van Steenburgh

    forge:tv/6391

     
  • Tim Van Steenburgh

    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -0,0 +1,11 @@
    +From IRC:
    +
    +tvansteenburgh
    +I would like to add this to the Application base class:
    +
    +    @property
    +    def sitemap(self):
    +        return [SitemapEntry(self.config.options.mount_label, '.')]
    +
    +There's no reason for Application to not implement this default.
    +Otherwise, subclasses need to provide `sitemap` just to get the tool to show up in the nav.
    
    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2013-06-28
    • Milestone: forge-jun-28 --> forge-jul-12
     
  • Dave Brondsema

    Dave Brondsema - 2013-07-01
    • QA: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2013-07-01
    • status: code-review --> closed
     

Log in to post a comment.