#6487 Fix icon loading & trove names in google code import

v1.0.0
closed
General
2015-08-20
2013-07-23
No
Traceback (most recent call last):
  File "/home/dbrondsema/dbrondsema-1019/forge/Allura/allura/model/monq_model.py", line 256, in __call__
    self.result = func(*self.args, **self.kwargs)
  File "/home/dbrondsema/dbrondsema-1019/forge/ForgeImporters/forgeimporters/google/tasks.py", line 32, in import_project_info
    extractor.get_icon()
  File "/home/dbrondsema/dbrondsema-1019/forge/ForgeImporters/forgeimporters/google/__init__.py", line 66, in get_icon
    fp_ish = urllib2.urlopen(icon_url)
  File "/var/local/env-allura/lib/python2.7/site-packages/timermiddleware/__init__.py", line 120, in __call__
    return self.run_and_log(self._inner, None, *args, **kwargs)
  File "/var/local/env-allura/lib/python2.7/site-packages/timermiddleware/__init__.py", line 125, in run_and_log
    return func(*args, **kwargs)
  File "/usr/lib64/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib64/python2.7/urllib2.py", line 392, in open
    protocol = req.get_type()
  File "/usr/lib64/python2.7/urllib2.py", line 254, in get_type
    raise ValueError, "unknown url type: %s" % self.__original
ValueError: unknown url type: /p/tortoisesvn/logo?cct=1374605992
Traceback (most recent call last):
  File "/home/dbrondsema/dbrondsema-1019/forge/Allura/allura/model/monq_model.py", line 256, in __call__
    self.result = func(*self.args, **self.kwargs)
  File "/home/dbrondsema/dbrondsema-1019/forge/ForgeImporters/forgeimporters/google/tasks.py", line 33, in import_project_info
    extractor.get_license()
  File "/home/dbrondsema/dbrondsema-1019/forge/ForgeImporters/forgeimporters/google/__init__.py", line 80, in get_license
    self.project.trove_license.append(trove._id)
AttributeError: 'NoneType' object has no attribute '_id'

Default image http://www.gstatic.com/codesite/ph/images/defaultlogo.png shouldn't be pulled in

Discussion

  • Dave Brondsema

    Dave Brondsema - 2013-07-23
    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2013-07-23

    allura:db/6487 (branched off of tv/6463)

     
  • Tim Van Steenburgh

    • QA: Tim Van Steenburgh
     
  • Tim Van Steenburgh

    • status: code-review --> closed
     

Log in to post a comment.