#6526 Fixes for individual tool importers

asf_release_1.0.1
closed
General
2013-08-28
2013-08-07
Dave Brondsema
No

Individual tool importer controllers will need their import_tool calls changed to be tasks. Perhaps create the tool right away, kick off the task, then redirect to the new tool with a flash message.

Other fixes are likely needed too, once this controller is exposed and can be tested.

Related

Tickets: #6482
Tickets: #6530

Discussion

  • Dave Brondsema
    Dave Brondsema
    2013-08-09

    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,3 +1,3 @@
    -Individual tool importer controllers will need their `import_tool` calls changed to be tasks.  Perhaps create the tool right away, kick off the task, then redirect to the new tool with a flash message.
    +Individual tool importer controllers will need their `import_tool` calls changed to be tasks.  <s>Perhaps create the tool right away, kick off the task, then redirect to the new tool with a flash message.</s>
    
     Other fixes are likely needed too, once this controller is exposed and can be tested.
    
    • Size: --> 1
     
    • status: open --> in-progress
    • assigned_to: Tim Van Steenburgh
     
    • status: in-progress --> open
    • assigned_to: Tim Van Steenburgh --> nobody
     
    • status: open --> in-progress
    • assigned_to: Tim Van Steenburgh
     
    • status: in-progress --> code-review
     
  • Branched off db/6482.

    forge:tv/6526
    googlecodewikiimporter:tv/6526
    tracwikiimporter:tv/6526

     
  • Dave Brondsema
    Dave Brondsema
    2013-08-23

    • Milestone: forge-aug-23 --> forge-sep-06
     
  • Dave Brondsema
    Dave Brondsema
    2013-08-27

    • QA: Dave Brondsema
     
  • Dave Brondsema
    Dave Brondsema
    2013-08-27

    • status: code-review --> in-progress
     
  • Dave Brondsema
    Dave Brondsema
    2013-08-27

    We should include the default mount point in the pre-submit error checking. If you leave it blank, the task can fail later with:

    Traceback (most recent call last):
      File "/home/dbrondsema/dbrondsema-1019/forge/Allura/allura/model/monq_model.py", line 258, in __call__
        self.result = func(*self.args, **self.kwargs)
      File "/nfs/home/dbrondsema/googlecodewikiimporter/googlecodewikiimporter/importer.py", line 47, in import_tool
        GoogleCodeWikiImporter().import_tool(c.project, c.user, **kw)
      File "/nfs/home/dbrondsema/googlecodewikiimporter/googlecodewikiimporter/importer.py", line 203, in import_tool
        mount_label=mount_label or 'Wiki',
      File "/home/dbrondsema/dbrondsema-1019/forge/Allura/allura/model/project.py", line 606, in install_app
        raise exceptions.ToolError(str(e))
    ToolError: Mount point "wiki" is already in use
    
     
  • Sure you were using the tv/6526 version of the Google wiki importer? I ask because the new validation schema in that branch is supposed to handle this.

     
    • status: in-progress --> code-review
    • Size: 1 --> 2
     
  • Force-pushed tv/6526.

     
  • Dave Brondsema
    Dave Brondsema
    2013-08-28

    • status: code-review --> closed
     
  • Dave Brondsema
    Dave Brondsema
    2013-08-28