Having only glanced at the code, not tested it, a few thoughts: Would it be better to put everything in the macro, e.g. [[gittip_button username=brondsem]] and not store it on the project? Although there might be some advantage of tracking it at the project level. If we do keep it on the metadata page, we should make sure that field is accessible for user-projects (many other metadata fields are not available for user-projects).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2013-08-15
Originally by: algorithms
I agree, the [[gittip_button username=foo]] format is better for this. I updated the pull request to reflect that change and add a test for the macro.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Originally by: algorithms
Pull request here: https://sourceforge.net/p/allura/git/merge-requests/23/
Created [#6570] to automatically link pull-requests to tickets.
Related
Tickets: #6570
Great to see this contribution :)
Having only glanced at the code, not tested it, a few thoughts: Would it be better to put everything in the macro, e.g.
[[gittip_button username=brondsem]]
and not store it on the project? Although there might be some advantage of tracking it at the project level. If we do keep it on the metadata page, we should make sure that field is accessible for user-projects (many other metadata fields are not available for user-projects).Originally by: algorithms
I agree, the [[gittip_button username=foo]] format is better for this. I updated the pull request to reflect that change and add a test for the macro.