#6733 When checking for DENY ACEs, get ProjectRole from Credentials cache

v1.0.1
closed
Tim Van Steenburgh
sf-1 (616)
General
Cory Johns
2015-08-20
2013-10-03
Tim Van Steenburgh
No

I came across this when researching slow-rendering discussion threads. The DENY check in has_access() results in many additional ProjectRole mongo queries when rendering a discussion thread.

Discussion

  • Tim Van Steenburgh - 2013-10-03
    • status: in-progress --> code-review
     

  • Tim Van Steenburgh - 2013-10-03

    allura:tv/6733

    Using full TMW logging to measure, this change saves 43 queries for every post in the discussion thread being rendered.

    I tested the Block User functionality to make sure it still works as expected.

     

  • Cory Johns - 2013-10-03
    • QA: Cory Johns
     

  • Cory Johns - 2013-10-03
    • status: code-review --> closed
     

Log in to post a comment.