#6922 GH import freezes on comment with image

v1.1.0
closed
nobody
General
Cory Johns
2015-08-20
2013-11-26
No

Testing rauhryan/huboard gets hung up. Running taskd manually and hitting ctrl-c let me see where it was at that point in time:

  File "/home/dbrondsema/dbrondsema-1019/forge/ForgeImporters/forgeimporters/base.py", line 122, in import_tool
    mount_point=mount_point, mount_label=mount_label, **kw)
  File "/home/dbrondsema/dbrondsema-1019/forge/ForgeImporters/forgeimporters/github/tracker.py", line 131, in import_tool
    self.process_comments(extractor, ticket, issue)
  File "/home/dbrondsema/dbrondsema-1019/forge/ForgeImporters/forgeimporters/github/tracker.py", line 182, in process_comments
    body, attachments = self._get_attachments(comment['body'])
  File "/home/dbrondsema/dbrondsema-1019/forge/ForgeImporters/forgeimporters/github/tracker.py", line 256, in _get_attachments
    for i, match in enumerate(found_matches):
  File "/var/local/env-allura/lib/python2.7/site-packages/async-0.6.1-py2.7-linux-x86_64.egg/async/__init__.py", line 20, in thread_interrupt_handler
    prev_handler(signum, frame)
KeyboardInterrupt

https://github.com/rauhryan/huboard/issues/48#issuecomment-5396859 is consistently the last comment to be saved to mongo. So something in the next one?

Related

Tickets: #6993

Discussion

  • Dave Brondsema

    Dave Brondsema - 2013-12-03
    • Labels: github, import --> import, github, 42cc
    • Status: open --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2013-12-12

    Closed #501. je/42cc_6922

    Fixed that error (and couple of others along the way) on that repo.

    Encountered other bug - imported attachments doesn't attach to comments (at least, they're not displayed on UI). Tested in master branch. I think you need another ticket for that.

     
  • Igor Bondarenko

    Igor Bondarenko - 2013-12-12
    • status: in-progress --> code-review
     
  • Cory Johns

    Cory Johns - 2013-12-12
    • QA: Cory Johns
     
  • Cory Johns

    Cory Johns - 2013-12-13
    • status: code-review --> closed
    • Milestone: forge-backlog --> forge-dec-13
     

Log in to post a comment.