#7021 Handle pgp-signed git commits

v1.2.0
closed
nobody
42cc (433)
General
Cory Johns
2015-08-20
2014-01-02
No
  File "/var/local/allura/ForgeGit/forgegit/model/git_repo.py", line 232, in refresh_commit_info
    tree_id=ci.tree.hexsha,
  File "/var/local/env-allura/lib/python2.7/site-packages/gitdb-0.5.4-py2.7-linux-x86_64.egg/gitdb/util.py", line 238, in __getattr__
    self._set_cache_(attr)
  File "/var/local/env-allura/lib/python2.7/site-packages/GitPython-0.3.2.RC1_20131017-py2.7.egg/git/objects/commit.py", line 133, in _set_cache_
    self._deserialize(StringIO(stream.read()))
  File "/var/local/env-allura/lib/python2.7/site-packages/GitPython-0.3.2.RC1_20131017-py2.7.egg/git/objects/commit.py", line 453, in _deserialize
    self.author.name = self.author.name.decode(self.encoding)
LookupError: unknown encoding: -----BEGIN PGP SIGNATURE-----

Discussion

  • Dave Brondsema

    Dave Brondsema - 2014-02-07
    • Labels: --> 42cc
    • Status: open --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2014-02-18

    It's know GitPython bug. There are merge request for fixing this, but unfortunately it isn't merged into main GitPython repo yet.

    We can use GitPython from this fork, or make our own from stable revision and apply similar changes to it. What do you think?

     
  • Dave Brondsema

    Dave Brondsema - 2014-02-19

    We've been compiling our other patches to GitPython at this repo/branch: https://github.com/johnsca/GitPython/tree/sf-master

    I'd recommend a test of merging the pull request with that branch, and see if it all works well.

     
  • Igor Bondarenko

    Igor Bondarenko - 2014-02-24
    • status: in-progress --> code-review
     
  • Cory Johns

    Cory Johns - 2014-03-03
    • QA: Cory Johns
     
  • Cory Johns

    Cory Johns - 2014-03-04
    • status: code-review --> closed
    • Milestone: forge-backlog --> forge-mar-7
     
  • Dave Brondsema

    Dave Brondsema - 2015-01-05
    • Milestone: unreleased --> asf_release_1.2.0
     

Log in to post a comment.