#7128 Change SVN's browse commits graph to direct SCM access

v1.2.0
closed
General
2015-08-20
2014-02-03
No

The "Browse Commits" interface can be incredibly slow, especially for larger repositories.

Override the commit_browser_data method in ForgeSVN to get data directly from svn instead of doing lots of mongo lookups and data manipulation. That implementation in Allura core seems much more complex than is necessary for SVN anyway, since SVN is always a single linear list of commits (no "real" branches, merges, or multiple heads to consider)

1 Attachments

Related

Tickets: #6707

Discussion

  • Dave Brondsema

    Dave Brondsema - 2014-02-07
    • Size: --> 2
     
  • Dave Brondsema

    Dave Brondsema - 2014-02-07
    • Milestone: forge-backlog --> forge-feb-21
     
  • Cory Johns

    Cory Johns - 2014-02-18
    • status: open --> in-progress
    • assigned_to: Cory Johns
     
  • Cory Johns

    Cory Johns - 2014-02-18

    allura:cj/7128

     
  • Cory Johns

    Cory Johns - 2014-02-18
    • status: in-progress --> code-review
     
  • Cory Johns

    Cory Johns - 2014-02-18
    • status: code-review --> in-progress
     
  • Cory Johns

    Cory Johns - 2014-02-18
    • status: in-progress --> code-review
     
  • Cory Johns

    Cory Johns - 2014-02-18

    allura:cj/7128

     
  • Tim Van Steenburgh

    • QA: Tim Van Steenburgh
     
  • Tim Van Steenburgh

    • status: code-review --> in-progress
     
  • Tim Van Steenburgh

    After clicking "Show More" I get 2 overlapping rows (see attachment).

     
  • Tim Van Steenburgh

    Also, I'm unable to click on the first commit (as in, the initial commit to the repo). Tested w/ svn and git.

     
  • Cory Johns

    Cory Johns - 2014-02-19

    Fixes pushed to:
    allura:cj/7128

     
  • Cory Johns

    Cory Johns - 2014-02-19
    • status: in-progress --> code-review
     
  • Tim Van Steenburgh

    Nice. At some point (maybe when we add paging for git/hg) it would be nice to show a "loading" indicator when Show More is clicked, so it's obvious something is actually happening.

     
  • Tim Van Steenburgh

    • status: code-review --> closed
     
  • Cory Johns

    Cory Johns - 2014-02-19

    Show More link definitely needs UI feedback. Also reduced the page size limit because commit_browser_data requests were taking ~ 4 sec in prod.

    allura:cj/7128

     
  • Cory Johns

    Cory Johns - 2014-02-19
    • status: closed --> code-review
     
  • Tim Van Steenburgh

    • status: code-review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2015-01-05
    • Milestone: unreleased --> asf_release_1.2.0
     

Log in to post a comment.