Apache Allura™ / Tickets / #7128 Change SVN's browse commits graph to direct SCM access

#7128 Change SVN's browse commits graph to direct SCM access

Milestone: v1.2.0

Status: closed

Owner: Cory Johns

Labels: indexless (10) performance (126) sf-2 (994)

Component: General

Reviewer: Tim Van Steenburgh

Updated: 2015-08-20

Created: 2014-02-03

Creator: Dave Brondsema

Private: No

The "Browse Commits" interface can be incredibly slow, especially for larger repositories.

Override the commit_browser_data method in ForgeSVN to get data directly from svn instead of doing lots of mongo lookups and data manipulation. That implementation in Allura core seems much more complex than is necessary for SVN anyway, since SVN is always a single linear list of commits (no "real" branches, merges, or multiple heads to consider)

1 Attachments

overlap.png

Dave Brondsema - 2014-02-07

Size: --> 2
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2014-02-07

Milestone: forge-backlog --> forge-feb-21
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2014-02-18

status: open --> in-progress

assigned_to: Cory Johns
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2014-02-18

allura:cj/7128

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2014-02-18

status: in-progress --> code-review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2014-02-18

status: code-review --> in-progress
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2014-02-18

status: in-progress --> code-review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2014-02-18

allura:cj/7128

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2014-02-19

QA: Tim Van Steenburgh
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2014-02-19

status: code-review --> in-progress
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2014-02-19

After clicking "Show More" I get 2 overlapping rows (see attachment).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2014-02-19

Also, I'm unable to click on the first commit (as in, the initial commit to the repo). Tested w/ svn and git.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2014-02-19

Fixes pushed to:
allura:cj/7128

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2014-02-19

status: in-progress --> code-review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2014-02-19

Nice. At some point (maybe when we add paging for git/hg) it would be nice to show a "loading" indicator when Show More is clicked, so it's obvious something is actually happening.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2014-02-19

status: code-review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2014-02-19

Show More link definitely needs UI feedback. Also reduced the page size limit because commit_browser_data requests were taking ~ 4 sec in prod.

allura:cj/7128

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cory Johns - 2014-02-19

status: closed --> code-review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Van Steenburgh - 2014-02-19

status: code-review --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2015-01-05

Milestone: unreleased --> asf_release_1.2.0
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Apache Allura™

Forge software for hosting software projects

Milestone

Searches

Help

#7128 Change SVN's browse commits graph to direct SCM access

Related

Discussion