#7130 Blob.next_commit and prev_commit should be removed

v1.2.0
closed
SCM
2015-08-20
2014-02-04
Cory Johns
No

Blob.context() (which is called when on the file view page) calls Blob.next_commit but the result is not used. Blob.next_commit walks down the commit tree to find the next commit that modified the file, which for rarely modified files can result in a lot of useless work.

Blob.prev_commit is more efficient, but is also not used.

Remove both, as well as associated tests in Allura/allura/tests/unit/test_repo.py, and ensure there is no visible impact to the UI of the file view page.

Discussion

  • Dave Brondsema
    Dave Brondsema
    2014-02-04

    • labels: --> performance
    • status: open --> in-progress
    • assigned_to: Cory Johns
    • Milestone: forge-backlog --> forge-feb-7
     
  • Cory Johns
    Cory Johns
    2014-02-04

    • status: in-progress --> code-review
    • Size: --> 1
     
  • Cory Johns
    Cory Johns
    2014-02-04

    allura:cj/7130

    I was mistaken about them not being used, but it's too inefficient to leave active.

     
  • Dave Brondsema
    Dave Brondsema
    2014-02-05

    • QA: Dave Brondsema
     
  • Dave Brondsema
    Dave Brondsema
    2014-02-05

    • status: code-review --> closed
     
  • Dave Brondsema
    Dave Brondsema
    2015-01-05

    • Milestone: unreleased --> asf_release_1.2.0