#7229 User profile 500s if activity has a commit ref

v1.2.0
closed
Cory Johns
activitystreams (47) sf-1 (616)
General
Dave Brondsema
2015-08-20
2014-02-28
Dave Brondsema
No

Would be nice if each section on the profile page could fail gracefully, in addition to fixing root error here.

File '/var/local/allura/Allura/allura/ext/user_profile/templates/user_index.html', line 20 in top-level template code
  {% extends g.theme.master %}
File '/var/local/allura/Allura/allura/templates/jinja_master/master.html', line 102 in top-level template code
  {% block content_base %}
File '/var/local/allura/Allura/allura/ext/user_profile/templates/user_index.html', line 49 in block "content_base"
  {{ section.display() }}
File '/var/local/allura/Allura/allura/ext/user_profile/user_main.py', line 268 in display
  'auth': AuthenticationProvider.get(request),
File '/var/local/allura/ForgeActivity/forgeactivity/main.py', line 268 in prepare_context
  activity.obj.project = activity_obj.project if activity_obj else None
AttributeError: 'Commit' object has no attribute 'project'

Related

Tickets: #7204

Discussion

  • Cory Johns - 2014-03-03
    • status: open --> in-progress
    • assigned_to: Cory Johns
    • Size: --> 1
     

  • Cory Johns - 2014-03-03

    allura:cj/7229

    I couldn't reproduce the commit activity not having a project, but this fix should handle it gracefully regardless.

     

  • Cory Johns - 2014-03-03
    • status: in-progress --> code-review
     

  • Dave Brondsema

    Dave Brondsema - 2014-03-03
    • status: code-review --> closed
    • QA: Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2015-01-05
    • Milestone: unreleased --> asf_release_1.2.0
     

Log in to post a comment.