#7239 Update feedparser

v1.2.0
closed
sf-1 (616)
General
Cory Johns
2015-08-20
2014-03-05
No

Our feedparser version is quite old, and a few bits of code need to be updated for it. E.g.

ERROR: test_html_sanitizer_youtube_iframe (allura.tests.test_utils.TestHTMLSanitizer)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/dbrondsema/dbrondsema-1014/forge/Allura/allura/tests/test_utils.py", line 250, in test_html_sanitizer_youtube_iframe
    '<div><iframe src="https://www.youtube.com/embed/kOLpSPEA72U?feature=oembed"></iframe></div>')
  File "/var/local/env-allura/lib/python2.7/site-packages/feedparser.py", line 1925, in feed
    sgmllib.SGMLParser.feed(self, data)
  File "/usr/lib64/python2.7/sgmllib.py", line 104, in feed
    self.goahead(0)
  File "/usr/lib64/python2.7/sgmllib.py", line 138, in goahead
    k = self.parse_starttag(i)
  File "/var/local/env-allura/lib/python2.7/site-packages/feedparser.py", line 1906, in parse_starttag
    j = self.__parse_starttag(i)
  File "/usr/lib64/python2.7/sgmllib.py", line 296, in parse_starttag
    self.finish_starttag(tag, attrs)
  File "/usr/lib64/python2.7/sgmllib.py", line 338, in finish_starttag
    self.unknown_starttag(tag, attrs)
  File "/home/dbrondsema/dbrondsema-1014/forge/Allura/allura/lib/utils.py", line 548, in unknown_starttag
    self.acceptable_elements.append('iframe')
AttributeError: 'set' object has no attribute 'append'

Discussion

  • Dave Brondsema

    Dave Brondsema - 2014-03-05

    db/7239

     
  • Dave Brondsema

    Dave Brondsema - 2014-03-05
    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2014-03-07
    • Milestone: forge-mar-7 --> forge-mar-21
     
  • Dave Brondsema

    Dave Brondsema - 2014-03-25
    • Milestone: forge-mar-21 --> forge-apr-4
     
  • Cory Johns

    Cory Johns - 2014-03-31
    • status: code-review --> closed
    • QA: Cory Johns
     
  • Dave Brondsema

    Dave Brondsema - 2015-01-05
    • Milestone: unreleased --> asf_release_1.2.0
     

Log in to post a comment.