#7293 Trove Category Admin Browse

v1.2.0
closed
sf-2 (995)
General
2015-08-20
2014-03-26
Chris Tsai
No

It's hard to figure out what's already in the Trove system (at "/categories/") without significant prior knowledge of its organization. A search function would make it much easier.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2014-03-26

    Or listing of the full tree so you can browse it too. (And then you can just search in the browser page)

     
  • Dave Brondsema

    Dave Brondsema - 2014-06-30
    • summary: Trove Category Admin Search --> Trove Category Admin Browse
    • Milestone: limbo --> forge-jul-11
     
  • Dave Brondsema

    Dave Brondsema - 2014-06-30
    • Size: --> 2
     
  • Alexander Luberg

    • status: open --> in-progress
    • assigned_to: Alexander Luberg
     
  • Alexander Luberg

    al/7293, still need to add a link to the browse page somewhere

     
  • Alexander Luberg

    • status: in-progress --> code-review
    • QA: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2014-07-07
    • status: code-review --> in-progress
     
  • Dave Brondsema

    Dave Brondsema - 2014-07-07

    Output looks good, but I would move it from the per-project admin to be under the site-wide trove editing page accessible at /categories.

     
  • Alexander Luberg

    moved to /categories/browse & added the link to /categories

     
  • Alexander Luberg

    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2014-07-08
    • status: code-review --> in-progress
     
  • Dave Brondsema

    Dave Brondsema - 2014-07-08

    Functionality and location look good now.

    For the test, we generally check for short snippets of HTML in the response (r or r.body or r.html) rather than checking r.controller_output. That helps confirm that the template is doing the proper thing too.

    The PEP8 cleanup commit has a few issues, you may want to check your editor settings or cleanup tool. First, the license text got unindented on the first lines. Second, my editor and the pep8 tool (shown below) actually complain about the moved "}" and that it was ok before.

    $ pep8 --max-line-length=119 Allura/allura/ext/admin/admin_main.py --show-source
    ...
    Allura/allura/ext/admin/admin_main.py:822:13: E124 closing bracket does not match visual indentation
                }
                ^
    ...
    
     
  • Alexander Luberg

    • status: in-progress --> code-review
     
  • Dave Brondsema

    Dave Brondsema - 2014-07-09
    • status: code-review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2014-07-09

    Nice using a Beautiful Soup object for your expected value. I think all our other tests compare a static string, but soup-to-soup avoids all whitespace issues.

     
  • Dave Brondsema

    Dave Brondsema - 2015-01-05
    • Milestone: unreleased --> asf_release_1.2.0
     

Log in to post a comment.