It's hard to figure out what's already in the Trove system (at "/categories/") without significant prior knowledge of its organization. A search function would make it much easier.
For the test, we generally check for short snippets of HTML in the response (r or r.body or r.html) rather than checking r.controller_output. That helps confirm that the template is doing the proper thing too.
The PEP8 cleanup commit has a few issues, you may want to check your editor settings or cleanup tool. First, the license text got unindented on the first lines. Second, my editor and the pep8 tool (shown below) actually complain about the moved "}" and that it was ok before.
$ pep8 --max-line-length=119 Allura/allura/ext/admin/admin_main.py --show-source
...
Allura/allura/ext/admin/admin_main.py:822:13: E124 closing bracket does not match visual indentation
}
^
...
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Nice using a Beautiful Soup object for your expected value. I think all our other tests compare a static string, but soup-to-soup avoids all whitespace issues.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Or listing of the full tree so you can browse it too. (And then you can just search in the browser page)
al/7293, still need to add a link to the browse page somewhere
Output looks good, but I would move it from the per-project admin to be under the site-wide trove editing page accessible at /categories.
moved to /categories/browse & added the link to /categories
Functionality and location look good now.
For the test, we generally check for short snippets of HTML in the response (
rorr.bodyorr.html) rather than checkingr.controller_output. That helps confirm that the template is doing the proper thing too.The PEP8 cleanup commit has a few issues, you may want to check your editor settings or cleanup tool. First, the license text got unindented on the first lines. Second, my editor and the pep8 tool (shown below) actually complain about the moved "}" and that it was ok before.
Nice using a Beautiful Soup object for your expected value. I think all our other tests compare a static string, but soup-to-soup avoids all whitespace issues.