#7323 ForgeHg: upgrade mercurial dependency

v1.0.0
closed
nobody
42cc (432)
General
2015-08-20
2014-04-12
No

The mercurial revision that ForgeHg/setup.py (and requirements-sf.txt) specify, is old and not available on pypi to install (although old releases are at http://mercurial.selenic.com/release/ if needed for testing, etc).

We should upgrade the ForgeHg code to use the latest mercurial version. http://mercurial.selenic.com/wiki/UpgradeNotes has release notes which we can compare against the code to find things that need to be changed.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2014-04-18
    • Labels: --> 42cc
    • Status: open --> in-progress
     
  • Igor Bondarenko - 2014-05-07
    • status: in-progress --> code-review
     
  • Igor Bondarenko - 2014-05-07

    Closed #576. forgehg:je/42cc_7323

    Updated mercurial to 3.0, adjusted some API calls (not many).

    There are a couple of things in changelog, that I was worried about, specifically:

    • hg heads now shows all branch heads, use --topo for old behavior
    • Bookmarks are no longer listed by hg tags

    But it turned out they affect only UI-related commands. Seems like we don't use anything else that may broke.

     
  • Dave Brondsema

    Dave Brondsema - 2014-05-13

    Did you find http://mercurial.selenic.com/wiki/ApiChanges ? I didn't find that document until now. It seems much more relevant for us than the UpgradeNotes doc.

     
  • Igor Bondarenko - 2014-05-14

    No, I did not. I've read through it now and I believe all relevant changes are made already. Specifically this:

    • scmutil.match (formerly cmdutil.match) now requires a context argument, typically "repo[None]"
    • repo._branchtags() is no more, maybe use repo.branchmap()

    Which was addressed in my first two commits in the branch: a6e843c and 25dc958. Other API methods wasn't used by ForgeHg.

     
  • Dave Brondsema

    Dave Brondsema - 2014-05-14

    Great :)

     
  • Dave Brondsema

    Dave Brondsema - 2014-05-15

    I've used https://sourceforge.net/p/coils/code/ as a test case of a large real-world hg repo. After cloning it locally and pushing into allura with the latest forgehg & mercurial, I've found:

     
  • Dave Brondsema

    Dave Brondsema - 2014-05-15
    • status: code-review --> in-progress
    • QA: Dave Brondsema
     
  • Igor Bondarenko - 2014-05-23
    • status: in-progress --> code-review
     
  • Igor Bondarenko - 2014-05-23

    Closed #593. Updated je/42cc_7323

    First point fixed. Indeed, branch list is in indeterminate order in both cases.

     
  • Dave Brondsema

    Dave Brondsema - 2014-06-02
    • status: code-review --> closed
    • Milestone: limbo --> forge-jun-13
     

Log in to post a comment.