#7333 svn web import tool breaks repos [ss7364]

v1.2.0
closed
nobody
42cc (433)
General
nobody
2015-08-20
2014-04-16
Chris Tsai
No

Immediately after using the web based svn import tool, the code browser starts throwing 403 errors. Subsequent changes to tool permissions don't appear to have any effect. The actual repo appears to import fine (tested via direct repo reads)

Import URLs tested:

svn://svn.berlios.de/gsmartcontrol
http://svn.berlios.de/svnroot/repos/gsmartcontrol
svn://svn.code.sf.net/p/strawhat/svn/

Discussion

  • Dave Brondsema

    Dave Brondsema - 2014-04-18
    • Labels: --> 42cc
    • Status: open --> in-progress
     
  • Igor Bondarenko

    Igor Bondarenko - 2014-04-30
    • status: in-progress --> code-review
     
  • Igor Bondarenko

    Igor Bondarenko - 2014-04-30

    Closed #578. je/42cc_7333

    The problem appeared after Ming update to Ming==0.4.4 (confirmed experimentally: 0.4.3 still works, and after 0.4.4 I've observed behavior described in this ticket)

    Basically, following happened:

    • svn import launches reclone task
    • reclone task deletes(!) Repository object for given repo
    • after that app.repo always returns None, which results in 403 error during security checks in repository controller

    I believe deleting Repository is wrong, since it gets created only when app is initially installed (none of the *clone* tasks/methods doesn't create it). Don't sure why it was added in first place (back in 2011).

    Why it worked in the first place? Well, I believe it was bug in Ming that actually updated objects marked for deletion, instead of deleting them (seems like this commit fixed that)

    The easiest way to fix this for repo, mentioned in ticket is to reinstall tool and run import again, after this change merged.

     
  • Dave Brondsema

    Dave Brondsema - 2014-04-30
    • status: code-review --> closed
    • Milestone: limbo --> forge-may-2
     
  • Dave Brondsema

    Dave Brondsema - 2014-04-30

    Thanks for the thorough report, I think you nailed it. BTW, I have found many times where big sweeping changes in 2011 had some hidden bugs that didn't surface until recently :)

     
  • Dave Brondsema

    Dave Brondsema - 2015-01-05
    • Milestone: unreleased --> asf_release_1.2.0
     

Log in to post a comment.